ProxyGenerator::isShortIdentifierGetter should check for file existance before reading the file

[VOONWerbeagentur]

We are using a module which is generating entity classes at runtime with Zend\Code\Generator which are only eval()'d and not persisted to the file system. When calling doctrine-module orm:generate:proxies lots of warnings are issued because the class files do not exist. Therefore, ProxyGenerator::isShortIdentifierGetter should check existance of class files before reading them with file().

Simply adding && file_exists($method->getDeclaringClass()->getFileName()) to the initialization of $cheapCheck does prevent those warnings.

[Ocramius]

@VOONWerbeagentur can you look for other getFileName calls throughout the source?

[VOONWerbeagentur]

@Ocramius: In doctrine/common, I found only two other calls of getFileName:

1. Doctrine\Common\Persistence\Mapping\Driver\AnnotationDriver::getAllClassNames
2. Doctrine\Common\Persistence\Mapping\Driver\StaticPHPDriver::getAllClassNames (which is obviously a copy of the first one)

But I think the calls made there are no Problem, as the file name is not used for reading the file.