feat: add support for IN (array) condition with update() and delete() calls

Author: simPod

src/Connection.php

@@ -365,9 +365,14 @@ private function getCriteriaCondition(array $criteria): array
                 continue;
             }
 
-            $columns[]    = $columnName;
-            $values[]     = $value;
-            $conditions[] = $columnName . ' = ?';
+            if (is_array($value)) {
+                $conditions[] = $columnName . ' IN (?)';
+            } else {
+                $conditions[] = $columnName . ' = ?';
+            }
+
+            $columns[] = $columnName;
+            $values[]  = $value;
         }
 
         return [$columns, $values, $conditions];
@@ -378,8 +383,8 @@ private function getCriteriaCondition(array $criteria): array
      *
      * Table expression and columns are not escaped and are not safe for user-input.
      *
-     * @param array<string, mixed>                                                                  $criteria
-     * @param array<int<0,max>, string|ParameterType|Type>|array<string, string|ParameterType|Type> $types
+     * @param array<string, mixed>                                                                                                        $criteria
+     * @param array<int<0,max>, string|ParameterType|ArrayParameterType|Type>|array<string, string|ArrayParameterType|ParameterType|Type> $types
      *
      * @return int|numeric-string The number of affected rows.
      *
@@ -442,9 +447,9 @@ public function getTransactionIsolation(): TransactionIsolationLevel
      *
      * Table expression and columns are not escaped and are not safe for user-input.
      *
-     * @param array<string, mixed>                                                                  $data
-     * @param array<string, mixed>                                                                  $criteria
-     * @param array<int<0,max>, string|ParameterType|Type>|array<string, string|ParameterType|Type> $types
+     * @param array<string, mixed>                                                                                                        $data
+     * @param array<string, mixed>                                                                                                        $criteria
+     * @param array<int<0,max>, string|ParameterType|ArrayParameterType|Type>|array<string, string|ParameterType|ArrayParameterType|Type> $types
      *
      * @return int|numeric-string The number of affected rows.
      *
@@ -518,10 +523,10 @@ public function insert(string $table, array $data, array $types = []): int|strin
     /**
      * Extract ordered type list from an ordered column list and type map.
      *
-     * @param array<int, string>                                                             $columns
-     * @param array<int, string|ParameterType|Type>|array<string, string|ParameterType|Type> $types
+     * @param array<int, string>                                                                                                   $columns
+     * @param array<int, string|ParameterType|ArrayParameterType|Type>|array<string, string|ParameterType|ArrayParameterType|Type> $types
      *
-     * @return array<int<0, max>, string|ParameterType|Type>
+     * @return array<int<0, max>, string|ParameterType|ArrayParameterType|Type>
      */
     private function extractTypeValues(array $columns, array $types): array
     {

tests/ConnectionTest.php

@@ -4,6 +4,7 @@
 
 namespace Doctrine\DBAL\Tests;
 
+use Doctrine\DBAL\ArrayParameterType;
 use Doctrine\DBAL\Cache\QueryCacheProfile;
 use Doctrine\DBAL\Configuration;
 use Doctrine\DBAL\Connection;
@@ -380,6 +381,41 @@ public function testUpdateWithIsNull(): void
         );
     }
 
+    public function testUpdateWithInArray(): void
+    {
+        $conn = $this->getExecuteStatementMockConnection();
+
+        $conn->expects(self::once())
+            ->method('executeStatement')
+            ->with(
+                'UPDATE TestTable SET text = ? WHERE id IN (?) AND name = ?',
+                [
+                    'some text',
+                    [1, 2],
+                    'foo',
+                ],
+                [
+                    'string',
+                    ArrayParameterType::STRING,
+                    'string',
+                ],
+            );
+
+        $conn->update(
+            'TestTable',
+            ['text' => 'some text'],
+            [
+                'id' => [1, 2],
+                'name' => 'foo',
+            ],
+            [
+                'text' => 'string',
+                'id' => ArrayParameterType::STRING,
+                'name' => 'string',
+            ],
+        );
+    }
+
     public function testDeleteWithIsNull(): void
     {
         $conn = $this->getExecuteStatementMockConnection();
@@ -405,6 +441,37 @@ public function testDeleteWithIsNull(): void
         );
     }
 
+    public function testDeleteWithInArray(): void
+    {
+        $conn = $this->getExecuteStatementMockConnection();
+
+        $conn->expects(self::once())
+            ->method('executeStatement')
+            ->with(
+                'DELETE FROM TestTable WHERE id IN (?) AND name = ?',
+                [
+                    [1, 2],
+                    'foo',
+                ],
+                [
+                    ArrayParameterType::STRING,
+                    'string',
+                ],
+            );
+
+        $conn->delete(
+            'TestTable',
+            [
+                'id' => [1, 2],
+                'name' => 'foo',
+            ],
+            [
+                'id' => ArrayParameterType::STRING,
+                'name' => 'string',
+            ],
+        );
+    }
+
     #[DataProvider('fetchModeProvider')]
     public function testFetch(string $method, callable $invoke, mixed $expected): void
     {