Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up source file main methods #263

Open
cipherboy opened this issue Sep 25, 2019 · 0 comments
Open

Clean up source file main methods #263

cipherboy opened this issue Sep 25, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers Help Wanted Extra attention is needed

Comments

@cipherboy
Copy link
Member

A number of files outside of the tests package have main methods. These include:

org/mozilla/jss/ssl/SSLClient.java:384:  public static void main(String argv[])  throws Exception
org/mozilla/jss/ssl/SSLTest.java:17:    public static void main(String[] args) {
org/mozilla/jss/ssl/SSLServer.java:264:    public static void main(String argv[]) throws Exception
org/mozilla/jss/util/Base64InputStream.java:225:    public static void main(String args[]) throws Exception {
org/mozilla/jss/util/UTF8Converter.java:221:	public static void main(String[] args) {
org/mozilla/jss/pkcs10/CertificationRequest.java:251:    public static void main(String argv[]) {
org/mozilla/jss/pkix/crmf/CertReqMsg.java:251:    public static void main(String args[]) {
org/mozilla/jss/pkix/crmf/CertTemplate.java:500:    public static void main(String args[]) {
org/mozilla/jss/pkix/cmmf/CertRepContent.java:120:    public static void main(String argv[]) {
org/mozilla/jss/pkix/primitive/Name.java:252:    public static void main(String args[]) {
org/mozilla/jss/pkix/cert/Certificate.java:264:    public static void main(String argv[]) {
org/mozilla/jss/asn1/SEQUENCE.java:626:    public static void main(String args[]) {
org/mozilla/jss/asn1/INTEGER.java:104:    public static void main(String args[]) {
org/mozilla/jss/asn1/SET.java:917:    public static void main(String args[]) {
org/mozilla/jss/pkcs12/PFX.java:320:    public static void main(String []args) {
org/mozilla/jss/netscape/security/extensions/NSCertTypeExtension.java:380:    public static void main(String[] argv) {
org/mozilla/jss/netscape/security/extensions/KerberosName.java:122:    public static void main(String[] argv) {
org/mozilla/jss/netscape/security/extensions/PresenceServerExtension.java:263:    public static void main(String args[]) {
org/mozilla/jss/netscape/security/extensions/SubjectInfoAccessExtension.java:220:    public static void main(String[] argv) {
org/mozilla/jss/netscape/security/extensions/AuthInfoAccessExtension.java:242:    public static void main(String[] argv) {
org/mozilla/jss/netscape/security/x509/CertificatePoliciesExtension.java:253:    public static void main(String args[]) {
org/mozilla/jss/netscape/security/x509/CRLDistributionPoint.java:254:    public static void main(String args[]) throws GeneralNamesException, IOException, InvalidBERException {
org/mozilla/jss/netscape/security/x509/IssuingDistributionPointExtension.java:359:    public static void main(String args[]) {
org/mozilla/jss/netscape/security/x509/CRLDistributionPointsExtension.java:237:    public static void main(String args[]) {
org/mozilla/jss/netscape/security/x509/IssuingDistributionPoint.java:274:    public static void main(String args[]) {
org/mozilla/jss/netscape/security/x509/FreshestCRLExtension.java:250:    public static void main(String args[]) {
org/mozilla/jss/provider/javax/crypto/JSSSecretKeyFactorySpi.java:275:    public static void main(String args[]) {

It'd be good to review these and either add them to the tests package as a unit test or remove them if they're unnecessary. Command line utilities should perhaps be migrated to a separate package or source file.

@cipherboy cipherboy added enhancement New feature or request good first issue Good for newcomers Help Wanted Extra attention is needed labels Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant