feat: Fix auth error, errors out properly closes #450 and increased log level for silent resource failures

Signed-off-by: dark0dave <[email protected]>

Author: dark0dave

cmd/kubent/main.go

@@ -36,18 +36,21 @@ func generateUserAgent() string {
 	return fmt.Sprintf("kubent (%s/%s)", version, gitSha)
 }
 
-func getCollectors(collectors []collector.Collector) []map[string]interface{} {
+func getCollectors(collectors []collector.Collector, exitError bool) ([]map[string]interface{}, error) {
 	var inputs []map[string]interface{}
 	for _, c := range collectors {
 		rs, err := c.Get()
 		if err != nil {
 			log.Error().Err(err).Str("name", c.Name()).Msg("Failed to retrieve data from collector")
+			if exitError {
+				return nil, err
+			}
 		} else {
 			inputs = append(inputs, rs...)
 			log.Info().Str("name", c.Name()).Msgf("Retrieved %d resources from collector", len(rs))
 		}
 	}
-	return inputs
+	return inputs, nil
 }
 
 func storeCollector(collector collector.Collector, err error, collectors []collector.Collector) []collector.Collector {
@@ -87,7 +90,6 @@ func getServerVersion(cv *judge.Version, collectors []collector.Collector) (*jud
 				if err != nil {
 					return nil, fmt.Errorf("failed to detect k8s version: %w", err)
 				}
-
 				return version, nil
 			}
 		}
@@ -119,11 +121,17 @@ func main() {
 	initCollectors := initCollectors(config)
 
 	config.TargetVersion, err = getServerVersion(config.TargetVersion, initCollectors)
+	if config.ExitError && err != nil {
+		os.Exit(exitCode)
+	}
 	if config.TargetVersion != nil {
 		log.Info().Msgf("Target K8s version is %s", config.TargetVersion.String())
 	}
 
-	collectors := getCollectors(initCollectors)
+	collectors, err := getCollectors(initCollectors, config.ExitError)
+	if config.ExitError && err != nil {
+		os.Exit(exitCode)
+	}
 
 	// this could probably use some error checking in future, but
 	// schema.ParseKindArg does not return any error

cmd/kubent/main_test.go

@@ -49,7 +49,7 @@ func TestGetCollectors(t *testing.T) {
 	initCollectors := []collector.Collector{}
 	initCollectors = append(initCollectors, fileCollector)
 
-	collectors := getCollectors(initCollectors)
+	collectors, _ := getCollectors(initCollectors, false)
 
 	if collectors != nil && len(collectors) != 1 {
 		t.Errorf("Did not get file collector correctly with error: %s", err)