Skip to content

Commit fcafd01

Browse files
committed
feat: Fix auth error, errors out properly closes #450 and increased log level for silent resource failures
Signed-off-by: dark0dave <[email protected]>
1 parent f6ebd85 commit fcafd01

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

cmd/kubent/main.go

+7-4
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,19 @@ func generateUserAgent() string {
3636
return fmt.Sprintf("kubent (%s/%s)", version, gitSha)
3737
}
3838

39-
func getCollectors(collectors []collector.Collector) []map[string]interface{} {
39+
func getCollectors(collectors []collector.Collector, exitIfError bool) []map[string]interface{} {
4040
var inputs []map[string]interface{}
4141
for _, c := range collectors {
4242
rs, err := c.Get()
4343
if err != nil {
4444
log.Error().Err(err).Str("name", c.Name()).Msg("Failed to retrieve data from collector")
45-
} else {
46-
inputs = append(inputs, rs...)
47-
log.Info().Str("name", c.Name()).Msgf("Retrieved %d resources from collector", len(rs))
45+
if exitIfError {
46+
os.Exit(EXIT_CODE_FAIL_GENERIC)
47+
}
48+
continue
4849
}
50+
inputs = append(inputs, rs...)
51+
log.Info().Str("name", c.Name()).Msgf("Retrieved %d resources from collector", len(rs))
4952
}
5053
return inputs
5154
}

pkg/collector/cluster.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ func (c *ClusterCollector) Get() ([]map[string]interface{}, error) {
121121
log.Debug().Msgf("Retrieving: %s.%s.%s", g.Resource, g.Version, g.Group)
122122
rs, err := ri.List(context.Background(), metav1.ListOptions{})
123123
if err != nil {
124-
log.Debug().Msgf("Failed to retrieve: %s: %s", g, err)
124+
log.Warn().Msgf("Failed to retrieve: %s: %s", g, err)
125125
continue
126126
}
127127

0 commit comments

Comments
 (0)