Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix labeling for additional file types #8

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix labeling for additional file types #8

wants to merge 13 commits into from

Conversation

akashchi
Copy link

@akashchi akashchi commented Apr 13, 2023 •
edited
Loading

Labeler does not work when additional file types, i.e. added, modified, etc. are specified.

PR Example & Pipeline Example.

Cause: forEach method's return was not collected properly -> the hasApplicableFiles function always returned undefined -> labels are not collected.

Fix: use for loop and correct early return.

Closes #9.

This was referenced Apr 13, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labeler does not work when additional file types are specified
1 participant
@akashchi