ArrayBuffer and outputType support for Packer #2920
Closed
joshkel
started this conversation in
Ideas / Requests
Replies: 1 comment 1 reply
-
I like the idea Let's go with option 3 and make Sure yes, if you can submit a PR, that would be great! |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
patchDocument's outputType parameter is very convenient: it allows me to use ArrayBuffer (for easier use from a Node.js worker), and it lets me easily change between output types via parameter if I ever need that. However,
Packer
doesn't support ArrayBuffer and doesn't offer anoutputType
parameter.Suggestion:
Packer.pack
orPacker.to
method that takes anoutputType
parameter.Packer.to...
methods to use this new method.Packer.toArrayBuffer
method for consistency with the existingPacker.to...
methods.If this seems worthwhile, I can submit a PR.
Beta Was this translation helpful? Give feedback.
All reactions