Skip to content

Build fails for arm/v7 due to Int/uint overflows #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kylebrandt opened this issue Feb 3, 2025 · 3 comments
Open

Build fails for arm/v7 due to Int/uint overflows #2837

kylebrandt opened this issue Feb 3, 2025 · 3 comments

Comments

@kylebrandt
Copy link
Contributor

When building with for arm, get some overflow errors on some constants.

Output:

Stderr:
# github.com/dolthub/go-mysql-server/sql/types
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/geometry.go:548:24: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1123:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1128:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1133:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1138:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1143:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1214:17: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1221:22: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1228:22: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1235:22: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.19.0/sql/types/number.go:1235:22: too many errors
@twaik
Copy link

twaik commented Apr 23, 2025

Reproducible with go1.24.1.linux-amd64 while cross-compiling for bionic i686 target.
CI run: https://github.com/termux/termux-packages/actions/runs/14625433243/job/41035684818 .

@twaik
Copy link

twaik commented Apr 23, 2025

Same happens with go1.24.2.

@timsehn
Copy link
Contributor

timsehn commented Apr 23, 2025

We don't use these systems but we'd happily take a contribution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants