Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema deletion + plan functionality #11

Closed
jrevillard opened this issue Aug 5, 2021 · 4 comments
Closed

Schema deletion + plan functionality #11

jrevillard opened this issue Aug 5, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@jrevillard
Copy link

Hello,

Thanks for this nice tool ! In your README you speak about the kafka-gitops analogy.

I see two differences mainly:

  • there is no real "plan" functionality. Does the validate CLI option query the schema-registry to see if there is an update to do or not ?
  • I played a bit and I see that if I remove a schema from the configuration, this later is not deleted from the schema registry: Is it intentional ? I personally prefer to have it removed but of course, I would need to be able to see it in a "plan" before

Best,
Jerome

@domnikl
Copy link
Owner

domnikl commented Aug 19, 2021

Hello Jerome,

first of all: thank you for considering schema-registry-gitops!

Right now, it does not really "plan" in the sense that it will check if there is an update to do. All it does is check if the changes are compatible. But it is on my roadmap to implement a real plan functionality like kafka-gitops does.

Not deleting anything is intentional as all the use cases I had where microservices where each service manages it's schemas itself and must not delete schemas that belong to other services. That is on the roadmap also, but it will not be default mode, rather be explicitely activated by a CLI switch.

Does that answer all your questions?

@jrevillard
Copy link
Author

Hi @domnikl ,

Thanks a lot for the explanation ! My objective is a bit more strict indeed as I do not want the applications register or update the schema outside of the CI.

FYI, in the meantime, I just made a PR on kafka-gitops for this functionality if you are interested or just curious ;-) : devshawn/kafka-gitops#76

Best,
Jerome

@domnikl domnikl added the enhancement New feature or request label Aug 23, 2021
@domnikl
Copy link
Owner

domnikl commented Aug 24, 2021

I implemented plan and delete in the current master - replacing validate as that must be done implicitely anyways. Will release it as a new major version soon. Your PR is very interesting, tough, thanks for the link!

@domnikl domnikl closed this as completed Aug 24, 2021
@jrevillard
Copy link
Author

Really nice @domnikl !

Just as of curiosity, how did you do the diff ? I wanted to do it in my MR but did not had time yet.

Best,
Jerome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants