-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema deletion + plan functionality #11
Comments
Hello Jerome, first of all: thank you for considering schema-registry-gitops! Right now, it does not really "plan" in the sense that it will check if there is an update to do. All it does is check if the changes are compatible. But it is on my roadmap to implement a real plan functionality like kafka-gitops does. Not deleting anything is intentional as all the use cases I had where microservices where each service manages it's schemas itself and must not delete schemas that belong to other services. That is on the roadmap also, but it will not be default mode, rather be explicitely activated by a CLI switch. Does that answer all your questions? |
Hi @domnikl , Thanks a lot for the explanation ! My objective is a bit more strict indeed as I do not want the applications register or update the schema outside of the CI. FYI, in the meantime, I just made a PR on kafka-gitops for this functionality if you are interested or just curious ;-) : devshawn/kafka-gitops#76 Best, |
I implemented plan and delete in the current master - replacing validate as that must be done implicitely anyways. Will release it as a new major version soon. Your PR is very interesting, tough, thanks for the link! |
Really nice @domnikl ! Just as of curiosity, how did you do the diff ? I wanted to do it in my MR but did not had time yet. Best, |
Hello,
Thanks for this nice tool ! In your README you speak about the kafka-gitops analogy.
I see two differences mainly:
Best,
Jerome
The text was updated successfully, but these errors were encountered: