Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gameServer클래스 리팩토링 #91

Open
dongcheolpark opened this issue Feb 2, 2022 · 1 comment
Open

gameServer클래스 리팩토링 #91

dongcheolpark opened this issue Feb 2, 2022 · 1 comment
Labels
수정사항 This doesn't seem right

Comments

@dongcheolpark
Copy link
Owner

게임 서버 클래스의 parsestring은 꽤 괜찮게 작동하는 것 처럼 보입니다. 하지만 객체지향적으로 보면 parsestring은 OCP를 위반하는 코드입니다. 따라서 parseString의 분기문을 Factory 패턴으로 변경해야 합니다.

@dongcheolpark dongcheolpark added the 수정사항 This doesn't seem right label Feb 2, 2022
@dongcheolpark
Copy link
Owner Author

dongcheolpark commented Feb 2, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
수정사항 This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant