Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should pyzmq be listed in setup.py or requirements,txt? #180

Open
suliuzh opened this issue Nov 18, 2020 · 0 comments
Open

should pyzmq be listed in setup.py or requirements,txt? #180

suliuzh opened this issue Nov 18, 2020 · 0 comments
Labels
needs-review

Comments

@suliuzh
Copy link

suliuzh commented Nov 18, 2020

Hi
I am wondering if pyzmq should be listed in setup.py or requirements,txt?
As we can see, pyzmq is used in xonsh/jupyter_kernel.py as a must. But when I use "pip install gitsome", it seems that pyzmq will not be installed automatically. So should pyzmq be listed as dependency?
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donnemartin @suliuzh