Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'list-tests: failed' still reporting successful tests. #142

Open
jcooke-impinj opened this issue Oct 5, 2021 · 7 comments · May be fixed by #222
Open

'list-tests: failed' still reporting successful tests. #142

jcooke-impinj opened this issue Oct 5, 2021 · 7 comments · May be fixed by #222
Assignees
@dharmendrasha

Comments

@jcooke-impinj
Copy link

jcooke-impinj commented Oct 5, 2021 •
edited
Loading

I'm trying to process a junit that exceeds the max report size, so I'm setting 'list-tests: failed' , but the test report is still showing all of the successful tests.

Run dorny/test-reporter@v1
  with:
    name: Results -> Nightly
    path: **/digital/verilog_sims/regression/list_results_*.xml
    reporter: java-junit
    max-annotations: 50
    list-tests: failed
    path-replace-backslashes: false
    list-suites: all
    fail-on-error: true
    only-summary: false
    token: ***


Creating test report Results -> Nightly
  Processing test results from digital/verilog_sims/regression/list_results_all.xml
  Creating check run Results -> Nightly
  Creating report summary
  Generating check run summary
  Warning: Test report summary exceeded limit of 65535 bytes and will be trimmed
  Creating annotations
  Updating check run conclusion (failure) and output
  Check run create response: 200

Resulting report:
image
NickCraver added a commit to StackExchange/StackExchange.Redis that referenced this issue Jan 28, 2022
@NickCraver
This doesn't work work
d6c096e 
Bleh. dorny/test-reporter#142
@siegfriedpammer
Copy link

I am having the same problem. @dorny I would like to contribute a fix for this. Could you please provide some information on how to set up the project locally for development? Note: I have only very little experience with type-script.

See

test-reporter/src/report/get-report.ts

Lines 230 to 240 in a585725

sections.push(grp.name)
}
const space = grp.name ? ' ' : ''
for (const tc of grp.tests) {
const result = getResultIcon(tc.result)
sections.push(`${space}${result} ${tc.name}`)
if (tc.error) {
const lines = (tc.error.message ?? getFirstNonEmptyLine(tc.error.details)?.trim())
?.split(/\r?\n/g)
.map(l => '\t' + l)
if (lines) {
for context:

I suspect that a fix for this problem would be to add an additional if statement right after line 233.

if (options.listTests === 'failed' && tc.result !== 'failed') {
  continue;
}

Any guidance on how to contribute would be appreciated. Thanks!

@siegfriedpammer siegfriedpammer mentioned this issue Mar 6, 2022
Closed
siegfriedpammer added a commit to siegfriedpammer/test-reporting that referenced this issue Mar 6, 2022
@siegfriedpammer
Fixes dorny/test-reporter#142
d32eb7e
@siegfriedpammer siegfriedpammer mentioned this issue Mar 6, 2022
Merged
siegfriedpammer added a commit to siegfriedpammer/test-reporting that referenced this issue Mar 7, 2022
@siegfriedpammer
Fixes dorny/test-reporter#142
a6ef5f2
IanMoroney added a commit to phoenix-actions/test-reporting that referenced this issue Mar 7, 2022
@IanMoroney
Merge pull request #8 from siegfriedpammer/fix-listTests-failed
695f07a 
Fixes dorny/test-reporter#142
@siegfriedpammer
Copy link

This is now fixed at https://github.com/phoenix-actions/test-reporting

@vojtech-cerveny
Copy link

@dharmendrasha can you please check fix in phoenix-actions and implement it here as well? 🙏

@dharmendrasha
Copy link
Collaborator

Sorry guys for being late let me check on it

@dharmendrasha dharmendrasha self-assigned this Dec 28, 2022
@dharmendrasha dharmendrasha linked a pull request Dec 28, 2022 that will close this issue
Open
@dharmendrasha dharmendrasha linked a pull request Dec 28, 2022 that will close this issue
copied files from phoenix-actions/test-reporting #222
Open
@Mpdreamz Mpdreamz mentioned this issue Feb 7, 2023
Closed
@dejan-stojadinovic dejan-stojadinovic mentioned this issue Sep 18, 2023
Open
@frimmy
Copy link

frimmy commented Sep 21, 2023

this is still borked - switching to phoenix-actions/test-reporting fork for now..

@EduPonz
Copy link

EduPonz commented Feb 13, 2024

Hi everyone, I'm experiencing this issue as well (see here), is there anything I could do to get it to show only the failed tests?

@bendavies
Copy link

FYI this fix in the fork is here
phoenix-actions/test-reporting#8

fluecke pushed a commit to ulyssesapp/test-reporter that referenced this issue Apr 19, 2024
@siegfriedpammer @fluecke
Fixes dorny#142
20b9f1d
@cviddy cviddy mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dharmendrasha dharmendrasha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

copied files from phoenix-actions/test-reporting dorny/test-reporter
7 participants
@siegfriedpammer @bendavies @frimmy @EduPonz @vojtech-cerveny @dharmendrasha @jcooke-impinj