Skip to content

review and annotate all DOS structure sizes #95

Closed
@stsp

Description

@stsp

This routine review will hopefully allow us to
get the more stable core. DOS structs all should
have the particular size, but gcc can add paddings.
This caused lots of troubles on the initial development
steps, and I don't believe is entirely fixed now.
Even those structs that are marked as PACKED
are still under the risk, because they may contain
the internal structs that are still not packed.
Needs to annotate all DOS structs with
static_assert(sizeof(struct foo) == 0xfoo_len, "size mismatch");

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions