Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review and annotate all DOS structure sizes #95

Open
stsp opened this issue Jul 27, 2019 · 0 comments
Open

review and annotate all DOS structure sizes #95

stsp opened this issue Jul 27, 2019 · 0 comments

Comments

@stsp
Copy link
Member

stsp commented Jul 27, 2019

This routine review will hopefully allow us to
get the more stable core. DOS structs all should
have the particular size, but gcc can add paddings.
This caused lots of troubles on the initial development
steps, and I don't believe is entirely fixed now.
Even those structs that are marked as PACKED
are still under the risk, because they may contain
the internal structs that are still not packed.
Needs to annotate all DOS structs with
static_assert(sizeof(struct foo) == 0xfoo_len, "size mismatch");

stsp added a commit that referenced this issue Jul 27, 2019
@stsp stsp added the postponed label Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant