Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow methods to accept uuid's in upper or lowercase #617

Open
MoralCode opened this issue Nov 19, 2021 · 1 comment
Open

Allow methods to accept uuid's in upper or lowercase #617

MoralCode opened this issue Nov 19, 2021 · 1 comment

Comments

@MoralCode
Copy link

Took me a little while to figure out why I couldn't filter the discovered bluetooth devices with this library. Eventually found it when i noticed that the checks for particular characteristics call .toLowerCase() on the uuid's

Rather than writing documentation, It seems like a better solution is to just update the library to allow the user to provide UUID's in any case (including mixed) and have FlutterBleLib convert them to lowercase internally when performing comparisons.

What kind of places within this plugin are these kinds of comparisons made? Happy to make a pull request if this is something that is desirable

@MoralCode MoralCode changed the title Allow methods to accept uuid's in any case Allow methods to accept uuid's in upper or lowercase Nov 19, 2021
@MoralCode
Copy link
Author

It seems like this only affects published versions prior to the current nullsafe one since I am successfully able to use all-caps UUID's when importing the lib as a local path dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant