chore: reflect reviewed content

Author: filzrev

src/BenchmarkDotNet/Disassemblers/ClrMdArgs.cs

@@ -1,5 +1,4 @@
-using BenchmarkDotNet.Extensions;
-using BenchmarkDotNet.Serialization;
+using BenchmarkDotNet.Serialization;
 using System.Linq;
 using System.Text.Json.Serialization;
 
@@ -51,8 +50,5 @@ internal static ClrMdArgs FromArgs(string[] args)
 
         internal readonly string Serialize()
             => BdnJsonSerializer.Serialize(this);
-
-        public override string ToString()
-            => BdnJsonSerializer.Serialize(this, indentJson: true);
     }
 }

src/BenchmarkDotNet/Disassemblers/DisassemblyDiagnoser.cs

@@ -235,7 +235,9 @@ InProcessDiagnoserHandlerData IInProcessDiagnoser.GetHandlerData(BenchmarkCase b
             {
                 return default;
             }
-            return new(typeof(DisassemblyDiagnoserInProcessHandler), BuildClrMdArgs(benchmarkCase, "", 0).Serialize());
+
+            var clrMdArgs = BuildClrMdArgs(benchmarkCase, "", 0);
+            return new(typeof(DisassemblyDiagnoserInProcessHandler), BdnJsonSerializer.Serialize(clrMdArgs));
         }
 
         void IInProcessDiagnoser.DeserializeResults(BenchmarkCase benchmarkCase, string results)

src/BenchmarkDotNet/Helpers/FolderNameHelper.cs

@@ -1,5 +1,6 @@
 using BenchmarkDotNet.Extensions;
 using Perfolizer.Horology;
+using SimpleJson.Reflection;
 using System;
 using System.Globalization;
 using System.IO;
@@ -34,8 +35,8 @@ public static string ToFolderName(object? value)
                 return value.ToString();
             if (value is Type type)
                 return ToFolderName(type: type);
-            if (!valueType.IsValueType)
-                return valueType.Name; // TODO
+            if (!ReflectionUtils.GetTypeInfo(valueType).IsValueType)
+                return value.GetType().Name; // TODO
             if (value is TimeInterval interval)
                 return interval.Nanoseconds + "ns";
 

src/BenchmarkDotNet/Helpers/SourceCodeHelper.cs

@@ -1,10 +1,10 @@
-using System;
-using System.Collections.Generic;
+using BenchmarkDotNet.Extensions;
+using Perfolizer.Horology;
+using SimpleJson.Reflection;
+using System;
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Numerics;
-using BenchmarkDotNet.Extensions;
-using Perfolizer.Horology;
 
 #nullable enable
 
@@ -48,11 +48,11 @@ public static string ToSourceCode(object? value)
             }
             var valueType = value.GetType();
             if (valueType.IsEnum)
-                return $"({value.GetType().GetCorrectCSharpTypeName()})({ToInvariantCultureString(value)})";
+                return $"({valueType.GetCorrectCSharpTypeName()})({ToInvariantCultureString(value)})";
             if (value is Type type)
                 return "typeof(" + type.GetCorrectCSharpTypeName() + ")";
-            if (!valueType.IsValueType)
-                return "System.Activator.CreateInstance<" + value.GetType().GetCorrectCSharpTypeName() + ">()";
+            if (!ReflectionUtils.GetTypeInfo(valueType).IsValueType)
+                return "System.Activator.CreateInstance<" + valueType.GetCorrectCSharpTypeName() + ">()";
 
             switch (value) {
                 case TimeInterval interval:

src/BenchmarkDotNet/Serialization/BdnJsonSerializer.cs

@@ -4,7 +4,7 @@
 
 namespace BenchmarkDotNet.Serialization;
 
-public static partial class BdnJsonSerializer
+public static class BdnJsonSerializer
 {
     private static readonly JsonSerializerOptions DefaultOptions = new()
     {