Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building the entire aspnetcore repo (i.e. inside the VMR) desktop msbuild is chosen #58985

Open
ViktorHofer opened this issue Nov 15, 2024 · 0 comments
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@ViktorHofer
Copy link
Member

When building aspnetcore inside the VMR, desktop msbuild is being used which is required to build installers. The logic which msbuild engine to use lives here:

aspnetcore/eng/build.ps1

Lines 317 to 323 in eb68e01

# Don't bother with two builds if just one will build everything. Ignore super-weird cases like
# "-Projects ... -NoBuildJava -NoBuildManaged -NoBuildNodeJS". An empty `./build.ps1` command will build both
# managed and native projects.
$performDesktopBuild = $BuildInstallers -or $BuildNative
$performDotnetBuild = $BuildJava -or $BuildManaged -or $BuildNodeJS -or `
($All -and -not ($NoBuildJava -and $NoBuildManaged -and $NoBuildNodeJS)) -or `
($Projects -and -not ($BuildInstallers -or $specifiedBuildNative))

It might be ok to build the entire repository with desktop msbuild but ideally only the parts that need the desktop engine should build with it. Runtime does that which works really fine. Arcade already has a script that handles shelling out to desktop msbuild.

cc @wtgodbe

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

1 participant