Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixing named arguments + callback style and getter should not compile #17956

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Mixing named arguments + callback style and getter should not compile #17956

wants to merge 10 commits into from

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Nov 5, 2024 •
edited
Loading

Description

Fixes #17935

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

❗ Release notes required

@edgarfgp,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct

T-Gro
T-Gro reviewed Nov 7, 2024
View reviewed changes
src/Compiler/FSComp.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mixing named arguments + callback style and getter should not compile
2 participants
@edgarfgp @T-Gro