Skip to content

[msbuild] Make sure that non-iOS platforms build successfully on non-macOS platforms. Fixes #23101. #23158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

rolfbjarne
Copy link
Member

Make sure that non-iOS platforms build successfully on non-macOS platforms,
even if the actual output is not usable. This makes developing on Windows
easier.

Fixes #23101.

…rms unless we're building for a remotable platform."

This reverts commit cd4d6332d2f0a7a49b468e40c65f0e10c7dd3854.
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@AngeloLazzari
Copy link

@rolfbjarne rolfbjarne do you think this will be fixed? Do we need to speak with sentry? thank you

@rolfbjarne
Copy link
Member Author

@rolfbjarne rolfbjarne do you think this will be fixed? Do we need to speak with sentry? thank you

Yes, we'll fix it, but until we have an actual fix ready and merged I can't say when.

@AngeloLazzari
Copy link

@rolfbjarne rolfbjarne do you think this will be fixed? Do we need to speak with sentry? thank you

Yes, we'll fix it, but until we have an actual fix ready and merged I can't say when.

I hope asap because I think people are lookgin for alternatives... Can we do anything to speed up things? thank you !

@rolfbjarne
Copy link
Member Author

@rolfbjarne rolfbjarne do you think this will be fixed? Do we need to speak with sentry? thank you

Yes, we'll fix it, but until we have an actual fix ready and merged I can't say when.

I hope asap because I think people are lookgin for alternatives... Can we do anything to speed up things? thank you !

I'm working on it!

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #2955859] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #2955859] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #2955859] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #2955859] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #2955859] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #2955859] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #2955859] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #2955859] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 0 tests failed, 112 tests passed.

Failures

❌ windows tests

🔥 Failed catastrophically on VSTS: test results - windows (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 29558599c8150a70fc396ffb9af30bbb6545bcba [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants