MauiScrollView resets ContentOffset on first layout pass - fix #30453
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents MauiScrollView on iOS from inadvertently resetting its scroll position on the very first layout pass by adding an explicit check against _previousEffectiveUserInterfaceLayoutDirection.
- Introduces a guard so that on the initial layout pass (when
_previousEffectiveUserInterfaceLayoutDirectionisnull),ContentOffsetisn’t reset. - Ensures that on subsequent layout passes (when the layout direction is known), the old scroll offset logic still applies.
Comments suppressed due to low confidence (1)
src/Core/src/Platform/iOS/MauiScrollView.cs:67
- Consider adding a unit test to verify that on the initial layout pass (when
_previousEffectiveUserInterfaceLayoutDirectionis null) theContentOffsetremains unchanged, and that on subsequent passes it resets correctly.
else if (_previousEffectiveUserInterfaceLayoutDirection is not null)
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Jul 7, 2025
| @@ -64,7 +64,7 @@ public override void LayoutSubviews() | |||
| crossPlatformLayout.CrossPlatformArrange(new Rect(new Point(-horizontalOffset, 0), crossPlatformBounds)); | |||
| ContentOffset = new CGPoint(horizontalOffset, 0); | |||
| } | |||
| else | |||
| else if (_previousEffectiveUserInterfaceLayoutDirection is not null) | |||
There was a problem hiding this comment.
@mjo151 If you try this, could you share a repro sample? Would like to include a related test.
There was a problem hiding this comment.
I tested the build from this PR and it appears to fix the issue. I will see if I can create a simple repo sample.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
@mjo151 could you please verify if this PR fixes your issue, since you did not provide your repro so that I can test it
https://github.com/dotnet/maui/wiki/Testing-PR-Builds
Issues Fixed
Fixes #30147