[release/9.0.1xx-sr8] Pipeline fixes #30476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ai] Remove github mcp * [ci] Use certs/profile azdo task * Fix * again * try again * Access passworkd * again * legacy * needs to work like this * try again * try just mauiu-provisionator * [ci] clean * We need this as variable group from key vault doesn t work * Add comments * Try to always run on devdiv * fix * remove legacy * Maybe try fix on Azure pipelines hosts * Fix variable * Add continueOnError: true * Remove old provisioning # Conflicts: # eng/pipelines/common/provision.yml
* [ci] Fix variable condition * [ci] Fix small typo * [ci] We don t need that for device tests * [ci] Add remove /maui/Settings.plist * Remove build ipa * [ci] Don t fail builds if provisionator fails * Don t fail if issues found * [ci] Try main build without ProvisioningProfile * [iOS] Remove Entitlements from device tests * Essentials needs Entilements * [ci] Pass properties # Conflicts: # eng/pipelines/common/provision.yml
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Pull Request Overview
This PR cherry-picks pipeline-related fixes to restore and streamline the build and provisioning workflows.
- Remove obsolete iOS entitlements and outdated provisioning script.
- Consolidate and clean up variable definitions and pipeline templates.
- Update build scripts to adjust code-signing flags and platform version checks.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Graphics/tests/DeviceTests/Platforms/iOS/Entitlements.plist | Remove obsolete test entitlements file |
| eng/provisioning/provisioning.csx | Remove hardcoded Mac/iOS code-signing calls |
| eng/pipelines/common/variables.yml | Collapse multi-line signingCondition and drop unused vars |
| eng/pipelines/common/ui-tests-steps.yml | Remove deprecated skipProvisioning parameter |
| eng/pipelines/common/provision.yml | Revise skip logic and add specific Install tasks |
| eng/pipelines/common/maui-templates.yml | Clean up stray blank lines and commented template |
| eng/pipelines/common/maui-templates-steps.yml | Comment out fail-on-issue template |
| eng/devices/ios.cake | Replace IPA build flag with CodesignRequireProvisioningProfile |
| eng/devices/android.cake | Fix DEVICE_VERSION comparison (remove stray character) |
| eng/cake/dotnet.cake | Pass CodesignRequireProvisioningProfile=false via properties |
| .vscode/mcp.json | Strip out deprecated mcp server inputs |
Comments suppressed due to low confidence (3)
eng/pipelines/common/variables.yml:22
- [nitpick] This single-line condition is difficult to read and maintain. Consider breaking it back into multiple lines or extracting to a named variable to improve readability.
value: $[or( eq(variables['Sign'], 'true'), in(variables['Build.SourceBranch'], 'refs/heads/net9.0', 'refs/heads/net10.0', 'refs/heads/main', 'refs/heads/inflight/current' ), startsWith(variables['Build.SourceBranch'], 'refs/tags/'), startsWith(variables['Build.SourceBranch'], 'refs/heads/release/') )]
eng/pipelines/common/ui-tests-steps.yml:58
- The
provision.ymltemplate expects askipProvisionatorparameter, notskipProvisioning. Removing the wrong parameter without supplying the correct one may cause provisioning logic to misbehave.
parameters:
eng/devices/ios.cake:149
- Replacing the
/p:BuildIpa=trueflag withCodesignRequireProvisioningProfile=falsewill disable IPA creation; this likely prevents generating the .ipa artifact. Consider appending both/p:BuildIpa=trueand the new property, or verify that IPA output is still produced as expected.
.Append("/p:CodesignRequireProvisioningProfile=false")
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
cherry pick some commits to fix pipeline