Implement iOS/macOS secondary ToolbarItems - Shell #30480
+63
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for secondary toolbar items in Shell on iOS/macOS by introducing a new pull-down menu for items marked Secondary, and also updates the DatePicker API to allow nullable dates.
- Added
ToSecondarySubToolbarItemextension andSecondarySubToolbarItemclass - Modified Shell handlers to group secondary items under a menu button with configurable icon
- Changed
DatePickerproperties and event args to useDateTime?for nullable support
Reviewed Changes
Copilot reviewed 287 out of 1121 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Controls/src/Core/Compatibility/iOS/Extensions/ToolbarItemExtensions.cs | Added ToSecondarySubToolbarItem extension and SecondarySubToolbarItem class |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs | Updated UpdateToolbarItems to insert secondary items into a pull-down menu |
| src/Controls/src/Core/DatePicker/DatePicker.cs | Changed bindable Date, MinimumDate, MaximumDate and related APIs to nullable DateTime? |
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs:391
- Typo:
Viewcois undefined; this should beViewControllerto correctly reference the view controller instance.
break;
| @@ -25,6 +27,31 @@ public static UIBarButtonItem ToUIBarButtonItem(this ToolbarItem item, bool forc | |||
| return new PrimaryToolbarItem(item, forceName); | |||
| } | |||
|
|
|||
| internal static SecondarySubToolbarItem ToSecondarySubToolbarItem(this ToolbarItem item) | |||
There was a problem hiding this comment.
Add automated UI tests in TestCases.HostApp and TestCases.Shared.Tests to cover the new SecondarySubToolbarItem functionality so secondary toolbar menus are validated end-to-end.
Copilot uses AI. Check for mistakes.
| @@ -14,17 +14,17 @@ public partial class DatePicker : View, IFontElement, ITextElement, IElementConf | |||
| public static readonly BindableProperty FormatProperty = BindableProperty.Create(nameof(Format), typeof(string), typeof(DatePicker), "d"); | |||
|
|
|||
| /// <summary>Bindable property for <see cref="Date"/>.</summary> | |||
| public static readonly BindableProperty DateProperty = BindableProperty.Create(nameof(Date), typeof(DateTime), typeof(DatePicker), default(DateTime), BindingMode.TwoWay, | |||
| public static readonly BindableProperty DateProperty = BindableProperty.Create(nameof(Date), typeof(DateTime?), typeof(DatePicker), null, BindingMode.TwoWay, | |||
There was a problem hiding this comment.
Changing the Date bindable property's CLR type from DateTime to DateTime? is a public API signature change and may be breaking; ensure this is acceptable for a minor release.
Copilot uses AI. Check for mistakes.
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jul 8, 2025
There was a problem hiding this comment.
There are some build errors:
C:\a\_work\1\s\src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellPageRendererTracker.cs(395,9): error CS0103: The name 'Viewco' does not exist in the current context [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-ios18.5]
C:\a\_work\1\s\src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellPageRendererTracker.cs(397,22): error CS0103: The name 'navRenderer' does not exist in the current context [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-ios18.5]
C:\a\_work\1\s\src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellPageRendererTracker.cs(394,29): error CS8600: Converting null literal or possible null value to non-nullable type. [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-ios18.5]
C:\a\_work\1\s\src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellPageRendererTracker.cs(402,22): error CS8600: Converting null literal or possible null value to non-nullable type. [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-ios18.5]
C:\a\_work\1\s\src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellPageRendererTracker.cs(395,9): error CS0103: The name 'Viewco' does not exist in the current context [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-maccatalyst18.5]
C:\a\_work\1\s\src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellPageRendererTracker.cs(397,22): error CS0103: The name 'navRenderer' does not exist in the current context [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-maccatalyst18.5]
C:\a\_work\1\s\src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellPageRendererTracker.cs(394,29): error CS8600: Converting null literal or possible null value to non-nullable type. [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-maccatalyst18.5]
C:\a\_work\1\s\src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellPageRendererTracker.cs(402,22): error CS8600: Converting null literal or possible null value to non-nullable type. [C:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net10.0-maccatalyst18.5]
8 Error(s)
github-project-automation
bot
moved this from Todo
to Changes Requested
in MAUI SDK Ongoing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This PR is an extension for @jfversluis one's #28185 which implements iOS/macOS secondary ToolbarItems for shell pages
Issues Fixed
Fixes #815
Screen.Recording.2025-07-08.at.01.45.07.mov