-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Testing] Feature matrix UITest Cases for TwoPaneView Control #30610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Testing] Feature matrix UITest Cases for TwoPaneView Control #30610
Conversation
Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
@HarishKumarSF4517 Could you fix the conflict? |
b0b503b
to
839273a
Compare
|
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz, I have committed the Snapshots |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz, I have added the snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces comprehensive UI testing infrastructure for the TwoPaneView control. The PR adds Feature Matrix test pages to enable systematic testing of TwoPaneView functionality across different platforms, including layout modes, pane configurations, and visual properties.
Key Changes:
- Adds TwoPaneView Feature Matrix gallery entry with options page for configuring control properties
- Implements comprehensive UI test suite covering platform-specific layout behaviors (wide/tall modes, RTL, shadows)
- Creates ViewModel architecture with property binding for TwoPaneView configuration management
Reviewed Changes
Copilot reviewed 7 out of 53 changed files in this pull request and generated 13 comments.
Show a summary per file
File | Description |
---|---|
CorePageView.cs | Adds TwoPaneView Feature Matrix entry to the test gallery |
TwoPaneViewFeatureTests.cs | Comprehensive UI test suite with platform-specific conditional compilation |
TwoPaneViewControlPage.xaml | Main test page defining TwoPaneView layout with configurable properties |
TwoPaneViewControlPage.xaml.cs | Code-behind handling mode changes and navigation to options page |
TwoPaneViewOptionsPage.xaml | Configuration page with steppers, radio buttons, and checkboxes for TwoPaneView properties |
TwoPaneViewOptionsPage.xaml.cs | Event handlers for property changes and navigation logic |
TwoPaneViewViewModel.cs | ViewModel implementing INotifyPropertyChanged for data binding and property management |
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs
Outdated
Show resolved
Hide resolved
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
…TwoPaneViewFeatureTests.cs Co-authored-by: Copilot <[email protected]>
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request introduces a new feature: the
TwoPaneView
control, which is integrated into the existing framework to provide a dual-pane layout for enhanced UI flexibility. The changes include the addition of new pages, controls, and functionality to support this feature.Integration of
TwoPaneView
FeatureTwoPaneViewControlPage
in theCorePageView
to include theTwoPaneView
feature in the gallery.TwoPaneViewControlPage.xaml
to define the layout of theTwoPaneView
control, includingPane1
andPane2
with configurable properties likePanePriority
,FlowDirection
, and visibility toggles.TwoPaneViewControlPage.xaml.cs
) to handle events such as mode changes, navigation, and binding context updates.TwoPaneViewOptionsPage.xaml
to allow users to configure properties likeMinTallModeHeight
,MinWideModeWidth
,Pane1Length
,Pane2Length
, and mode configurations through UI controls such as steppers and radio buttons.TwoPaneViewOptionsPage.xaml.cs
to handle user interactions and update the view model with the selected configurations.TwoPaneView.mov