Skip to content

[Testing] Feature matrix UITest Cases for TwoPaneView Control #30610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

HarishKumarSF4517
Copy link
Contributor

This pull request introduces a new feature: the TwoPaneView control, which is integrated into the existing framework to provide a dual-pane layout for enhanced UI flexibility. The changes include the addition of new pages, controls, and functionality to support this feature.

Integration of TwoPaneView Feature

  • Added a new entry for the TwoPaneViewControlPage in the CorePageView to include the TwoPaneView feature in the gallery.
  • Introduced TwoPaneViewControlPage.xaml to define the layout of the TwoPaneView control, including Pane1 and Pane2 with configurable properties like PanePriority, FlowDirection, and visibility toggles.
  • Added corresponding code-behind (TwoPaneViewControlPage.xaml.cs) to handle events such as mode changes, navigation, and binding context updates.
  • Added TwoPaneViewOptionsPage.xaml to allow users to configure properties like MinTallModeHeight, MinWideModeWidth, Pane1Length, Pane2Length, and mode configurations through UI controls such as steppers and radio buttons.
  • Implemented logic in TwoPaneViewOptionsPage.xaml.cs to handle user interactions and update the view model with the selected configurations.
TwoPaneView.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 14, 2025
Copy link
Contributor

Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jul 14, 2025
@jsuarezruiz
Copy link
Contributor

@HarishKumarSF4517 Could you fix the conflict?

@HarishKumarSF4517 HarishKumarSF4517 force-pushed the feature_matrix_twopaneview branch from b0b503b to 839273a Compare July 14, 2025 12:58
@anandhan-rajagopal anandhan-rajagopal added area-testing Unit tests, device tests area-controls-twopaneview TwoPaneView / DualScreen labels Jul 14, 2025
@HarishKumarSF4517
Copy link
Contributor Author

@HarishKumarSF4517 Could you fix the conflict?
@jsuarezruiz , I have resolved the conflicts

@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots, already available in the latest build.
image
Could you commit the images?

@HarishKumarSF4517
Copy link
Contributor Author

Hi @jsuarezruiz, I have committed the Snapshots

@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots on Windows.
image

@HarishKumarSF4517
Copy link
Contributor Author

Hi @jsuarezruiz, I have added the snapshots

@HarishKumarSF4517 HarishKumarSF4517 marked this pull request as ready for review July 21, 2025 10:30
@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 10:30
@HarishKumarSF4517 HarishKumarSF4517 requested a review from a team as a code owner July 21, 2025 10:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces comprehensive UI testing infrastructure for the TwoPaneView control. The PR adds Feature Matrix test pages to enable systematic testing of TwoPaneView functionality across different platforms, including layout modes, pane configurations, and visual properties.

Key Changes:

  • Adds TwoPaneView Feature Matrix gallery entry with options page for configuring control properties
  • Implements comprehensive UI test suite covering platform-specific layout behaviors (wide/tall modes, RTL, shadows)
  • Creates ViewModel architecture with property binding for TwoPaneView configuration management

Reviewed Changes

Copilot reviewed 7 out of 53 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
CorePageView.cs Adds TwoPaneView Feature Matrix entry to the test gallery
TwoPaneViewFeatureTests.cs Comprehensive UI test suite with platform-specific conditional compilation
TwoPaneViewControlPage.xaml Main test page defining TwoPaneView layout with configurable properties
TwoPaneViewControlPage.xaml.cs Code-behind handling mode changes and navigation to options page
TwoPaneViewOptionsPage.xaml Configuration page with steppers, radio buttons, and checkboxes for TwoPaneView properties
TwoPaneViewOptionsPage.xaml.cs Event handlers for property changes and navigation logic
TwoPaneViewViewModel.cs ViewModel implementing INotifyPropertyChanged for data binding and property management

HarishKumarSF4517 and others added 12 commits July 21, 2025 16:14
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-twopaneview TwoPaneView / DualScreen area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants