-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Fixed: Image randomly disappears while switching tabs #30763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Android] Fixed: Image randomly disappears while switching tabs #30763
Conversation
Hey there @@Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
cc @albyrock87 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue on Android where images would randomly disappear when switching between tabs. The root cause was that the CompleteLoad()
method wasn't being called on Android, preventing the IsLoading
state from being properly reset in the image source manager.
Key changes:
- Added missing
CompleteLoad()
call for Android platform inImageSourcePartLoader.cs
- Restored platform parity by ensuring all platforms properly complete the loading process
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
I tested CI packages and I can confirm it fixes the issue. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/backport to release/9.0.1xx-sr9 |
Started backporting to release/9.0.1xx-sr9: https://github.com/dotnet/maui/actions/runs/16530674834 |
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Root Cause of the issue
Description of Change
The CompleteLoad() method is now called uniformly across all platforms.
Initially, CompleteLoad() was called for all platforms.
Later, in PR #16864, the logic was adjusted to handle blurry FontImageSource icons on iOS. As part of that change, the condition was split between iOS & Windows and Android & Tizen. However, it seems the CompleteLoad() call was mistakenly omitted for Android.
Issues Fixed
Fixes #30728
Tested the behaviour in the following platforms
Screenshot
Before-Fix.mov
After-Fix.mov