[Testing] - Modified Feature matrix UITest Cases for Entry Control #30789
Conversation
|
Hey there @@nivetha-nagalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
nivetha-nagalingam
changed the title
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Entry Control test UI to improve accessibility and simplify the interface by moving the "Options" button from the toolbar to the main page layout. The changes also include UI adjustments and corresponding test updates to accommodate the new button placement.
Key changes:
- Replaced toolbar-based "Options" button with an in-page button for better accessibility
- Updated UI test automation to work with the new button location and flow
- Made comprehensive font size adjustments throughout the options page for consistency
Reviewed Changes
Copilot reviewed 3 out of 155 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| EntryControlPage.xaml | Moved "Options" button from toolbar to main page layout and adjusted label margin |
| EntryOptionsPage.xaml | Replaced toolbar "Apply" button with in-page button, standardized font sizes to 10pt, and reorganized layout structure |
| EntryFeatureTests.cs | Updated test automation to navigate through new Options flow and handle UI element changes |
| <Button Text="Apply" | ||
| FontSize="14" | ||
| Clicked="ApplyButton_Clicked" | ||
| AutomationId="ApplyButton"/> |
There was a problem hiding this comment.
The AutomationId has been changed from "Apply" to "ApplyButton". This could break existing tests that expect "Apply". AutomationIds should be unique and consistent across the codebase to ensure WaitForElement calls work correctly.
Copilot uses AI. Check for mistakes.
| <Button Text="Options" | ||
| FontSize="11" | ||
| Clicked="NavigateToOptionsPage_Clicked" | ||
| AutomationId="OptionsButton"/> |
There was a problem hiding this comment.
The new AutomationId "OptionsButton" differs from the test expectation of "Options". The test in EntryFeatureTests.cs expects AutomationId="Options" but this button uses "OptionsButton", which will cause test failures.
Copilot uses AI. Check for mistakes.
| App.WaitForElement("Apply"); | ||
| App.Tap("Apply"); |
There was a problem hiding this comment.
This test is expecting AutomationId="Apply" but the corresponding button in EntryOptionsPage.xaml now has AutomationId="ApplyButton". This will cause the test to fail when trying to locate the Apply button.
| App.WaitForElement("Apply"); | |
| App.Tap("Apply"); | |
| App.WaitForElement("ApplyButton"); | |
| App.Tap("ApplyButton"); |
Copilot uses AI. Check for mistakes.
| App.WaitForElement("Apply"); | ||
| App.Tap("Apply"); |
There was a problem hiding this comment.
This test is expecting AutomationId="Apply" but the corresponding button in EntryOptionsPage.xaml now has AutomationId="ApplyButton". This will cause the test to fail when trying to locate the Apply button.
| App.WaitForElement("Apply"); | |
| App.Tap("Apply"); | |
| App.WaitForElement("ApplyButton"); | |
| App.Tap("ApplyButton"); |
Copilot uses AI. Check for mistakes.
| App.WaitForElement("Apply"); | ||
| App.Tap("Apply"); |
There was a problem hiding this comment.
This test is expecting AutomationId="Apply" but the corresponding button in EntryOptionsPage.xaml now has AutomationId="ApplyButton". This will cause the test to fail when trying to locate the Apply button.
| App.WaitForElement("Apply"); | |
| App.Tap("Apply"); | |
| App.WaitForElement("ApplyButton"); | |
| App.Tap("ApplyButton"); |
Copilot uses AI. Check for mistakes.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request makes updates to the
EntryControlPage.xamlfile to improve the layout and simplify the user interface by replacing the toolbar-based "Options" button with an in-page button. Below are the most important changes:UI Layout Improvements:
Optionsbutton directly within the page layout, with propertiesText="Options",FontSize="11", and aClickedevent handler (NavigateToOptionsPage_Clicked). This replaces the toolbar item for better accessibility.Code Simplification:
<ContentPage.ToolbarItems>section, which previously contained the "Options" button. This change simplifies the structure by consolidating the button into the main layout.Minor Adjustments:
Marginproperty of the "Entry Control" label to improve spacing consistency in the layout.