[Android, iOS, MacOS] Fixed Entry ClearButton Color Not Updating on AppThemeBinding Change #30817
+101
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
jsuarezruiz
added
platform/macos
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
reviewed
Jul 25, 2025
| if (handler is EntryHandler platformHandler && platformHandler._clearButtonVisible) | ||
| { | ||
| // Update the clear button color to match the text color | ||
| handler.PlatformView?.UpdateClearButtonColor(entry.TextColor, platformHandler.GetClearButtonDrawable()); |
There was a problem hiding this comment.
There is not changes in Windows, there behavior is currently aligned with this changes? should we apply changes on Windows too?
There was a problem hiding this comment.
There is not changes in Windows, there behavior is currently aligned with this changes? should we apply changes on Windows too?
Hi @jsuarezruiz ,
On Windows platform, the clear button icon color updates correctly when the theme changes, as handled in the TextBoxExtensions.cs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Root cause
Description of Change
Validated the behaviour in the following platforms
Issues Fixed
Fixes #19997
Output images
Android
Before_Android.mov
After_Android.mov
iOS
Before_iOS.mov
After_iOS.mov
macOS
Before_macOS.mov
After_macOS.mov