Skip to content

[Net10.0] Toolbar item - IconColor property #30826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: net10.0
Choose a base branch
from
Draft

[Net10.0] Toolbar item - IconColor property #30826

wants to merge 1 commit into from
+26 −0

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jul 25, 2025 •
edited
Loading

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This PR introduces a new IconColor bindable property for ToolbarItem that allows developers to customize the color of toolbar icons directly in XAML or code, bringing more flexibility and platform consistency to the appearance of toolbars.

<ContentPage.ToolbarItems>
       <ToolbarItem  IconColor="Blue">
              <ToolbarItem.IconImageSource>
                     <FileImageSource File="dotnet_bot.png"/>
              </ToolbarItem.IconImageSource>
       </ToolbarItem>
</ContentPage.ToolbarItems>

Issues Fixed

Fixes #30818

Screen.Recording.2025-07-25.at.02.09.50.mov

@kubaflo kubaflo changed the base branch from main to net10.0 July 25, 2025 00:15
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 25, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo changed the title Toolbar item color [Net10.0] Toolbar item - IconColor property Jul 25, 2025
@kubaflo kubaflo self-assigned this Jul 25, 2025
@kubaflo kubaflo mentioned this pull request Jul 25, 2025
Open
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz
jsuarezruiz requested changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include a related tests?

src/Controls/src/Core/Compatibility/iOS/Extensions/ToolbarItemExtensions.cs
}
else
{
Image = result?.Value.ImageWithRenderingMode(UIImageRenderingMode.AlwaysTemplate);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should happen when result?.Value is null here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Requested changes must be addressed to merge this pull request.

Assignees

@kubaflo kubaflo

Labels
community ✨ Community Contribution proposal/open t/enhancement ☀️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubaflo @jsuarezruiz