Skip to content

Commit 77c72dd

Browse files
authored
Fix installation error for ClickOnce SF apps that have an application icon set (#7761)
Installation of ClickOnce app as a Single-File with an Application Icon project property set fails to install. Include _DeploymentManifestIconFile itemgroup to _ClickOnceFiles itemgroup in Single-File mode. Verified publish and installation of all ClickOnce configurations (FDD and SC) with WPF and Forms app. Fixes AB#1555818.
1 parent 9d94176 commit 77c72dd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: src/Tasks/Microsoft.Common.CurrentVersion.targets

+2-2
Original file line numberDiff line numberDiff line change
@@ -4355,9 +4355,9 @@ Copyright (C) Microsoft Corporation. All rights reserved.
43554355
<_ClickOnceFiles Include="@(ContentWithTargetPath);@(_DeploymentManifestIconFile);@(AppConfigWithTargetPath);@(NetCoreRuntimeJsonFilesForClickOnce);@(_ClickOnceRuntimeCopyLocalItems)"/>
43564356
</ItemGroup>
43574357

4358-
<!-- For single file publish, we need to include the SF bundle EXE and files excluded from the bundle EXE in the clickonce manifest -->
4358+
<!-- For single file publish, we need to include the SF bundle EXE, application icon file and files excluded from the bundle EXE in the clickonce manifest -->
43594359
<ItemGroup Condition="'$(PublishSingleFile)' == 'true'">
4360-
<_ClickOnceFiles Include="$(PublishedSingleFilePath)"/>
4360+
<_ClickOnceFiles Include="$(PublishedSingleFilePath);@(_DeploymentManifestIconFile)"/>
43614361
<_ClickOnceFiles Include="@(_FilesExcludedFromBundle)"/>
43624362

43634363
<!-- Include file association icons from Content as loose files -->

0 commit comments

Comments
 (0)