Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution doesn't respect WarningsNotAsErrors #10877

Open
rainersigwald opened this issue Oct 23, 2024 · 0 comments · May be fixed by #10942
Open

Solution doesn't respect WarningsNotAsErrors #10877

rainersigwald opened this issue Oct 23, 2024 · 0 comments · May be fixed by #10942
Assignees
@SimaTian
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Engine Issues impacting the core execution of targets and tasks. Priority:1 Work that is critical for the release, but we could probably ship without triaged

Comments

@rainersigwald
Copy link
Member

The promotion of the "plain property" version of some warning-related settings:

msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets

Lines 668 to 672 in 69b3e7a

<PropertyGroup>
<MSBuildWarningsAsMessages Condition="'$(MSBuildWarningsAsMessages)'==''">$(NoWarn)</MSBuildWarningsAsMessages>
<MSBuildWarningsAsErrors Condition="'$(MSBuildWarningsAsErrors)'==''">$(WarningsAsErrors)</MSBuildWarningsAsErrors>
<MSBuildWarningsNotAsErrors Condition="'$(MSBuildWarningsNotAsErrors)'==''">$(WarningsNotAsErrors)</MSBuildWarningsNotAsErrors>
</PropertyGroup>

Is in Microsoft.Common.CurrentVersion.targets, which is not imported into solution metaprojects. This means that any warnings raised in the solution itself (like in NuGet operations) may be promoted to error even if $(WarningsNotAsErrors) includes them.

This is very related to #10873 and we should consider fixing both by looking at the unprefixed versions in the engine (if the prefixed version is unset) rather than requiring XML logic to do it.
@rainersigwald rainersigwald added Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Engine Issues impacting the core execution of targets and tasks. labels Oct 23, 2024
@rainersigwald rainersigwald mentioned this issue Oct 23, 2024
Open
@maridematte maridematte added Priority:1 Work that is critical for the release, but we could probably ship without triaged labels Oct 29, 2024
@SimaTian SimaTian linked a pull request Nov 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimaTian SimaTian

Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Engine Issues impacting the core execution of targets and tasks. Priority:1 Work that is critical for the release, but we could probably ship without triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add WarningsAsMessages, WarningsAsErrors, WarningsNotAsErrors and Tre… dotnet/msbuild
3 participants
@rainersigwald @SimaTian @maridematte