-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Snap for VS 18.3 and update branding to VS 18.4 #13005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @@copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Co-authored-by: ViktorHofer <[email protected]>
|
@copilot Update the |
The PackageValidationBaselineVersion is already set to 18.0.2, which is the latest stable version of Microsoft.Build on nuget.org. This value was already correct before my changes and remains unchanged in commit 2672911. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Update the |
Co-authored-by: ViktorHofer <[email protected]>
Updated in commit 585e42a. The vs18.0 element now merges to vs18.3, and vs18.3 merges to main. |
|
@copilot Update the .config/git-merge-flow-config.jsonc file and add "vs18.4" element that has a MergeToBranch key pointing to the "main" branch. Update the "vs18.3" element's MergeToBranch key to "vs18.4". |
Co-authored-by: ViktorHofer <[email protected]>
Updated in commit 7c1771d. Added vs18.4 element with MergeToBranch pointing to main, and updated vs18.3 to merge to vs18.4. |
Co-authored-by: ViktorHofer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates MSBuild version branding from 18.3 to 18.4, following the established pattern from PR #12786. The changes configure the infrastructure for the new vs18.4 servicing branch, enabling proper CI/CD pipelines and merge flow automation.
Changes:
- Updated version prefix from 18.3.0 to 18.4.0
- Configured VS insertion pipeline to support the new vs18.4 branch and rel/d18.4 target
- Established merge flow chain: vs18.0 → vs18.3 → vs18.4 → main
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Versions.props | Bumped VersionPrefix from 18.3.0 to 18.4.0 for version branding |
| azure-pipelines/vs-insertion.yml | Added rel/d18.4 target branch and vs18.4 branch mapping for CI/CD automation |
| .config/git-merge-flow-config.jsonc | Configured merge flow chain to include vs18.4 between vs18.3 and main |
Work item (Internal use):
Summary
Updates MSBuild version branding from 18.3 to 18.4 following the pattern established in #12786.
Changes:
eng/Versions.props: BumpVersionPrefixfrom18.3.0to18.4.0azure-pipelines/vs-insertion.yml: Addrel/d18.4target branch andvs18.4branch mapping.config/git-merge-flow-config.jsonc: Configure merge flow chain as vs18.0 → vs18.3 → vs18.4 → mainNote: Creating the
vs18.3servicing branch requires write permissions and must be done separately.Customer Impact
None. Branding update only affects internal version strings and CI/CD pipeline configuration for VS insertions and branch merge flows.
Regression?
No. Configuration-only changes to version strings, build pipeline mappings, and merge flow automation.
Testing
18.4.0-devRisk
Low. Minimal surface area—version string, pipeline configuration, and merge flow updates following established pattern from previous version bumps.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.