-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Test failure in System.Formats.Asn1 ReadVeryLongOid_WithAppContext: could not load file or assembly in NET48 #104647
Comments
Tagging subscribers to this area: @dotnet/area-system-formats-asn1, @bartonjs, @vcsjones |
@dotnet/area-system-formats-asn1 I see this happening often in servicing. It's now going to be carried into the August Release. PR: #104925 Is this a concerning error? |
It seems that it's a new test that has been recently backported to 6.0 in #104624 and 8.0 in #104623 (cc @bartonjs who has most likely authored it) The failure does not seem to be a product issue, more like a testing problem? The code executed by the remote executor fails to load the assembly, because there is a manifest mismatch.
@carlossanlop @ericstj what could have caused such an exception? My only idea for now it to disable it for Full Framework (because it seems to be the only affected configuration?). |
Remote executor needs to be run with the same app.config as the test assembly. Since it's not getting the test assembly's app.config it's missing bindingRedirects. I see remoteExecutor passes the deps and runtimeconfig for .NETCore processes (solving a similar problem). I bet it's never been plumbed for .NETFramework and folks don't notice except in servicing. There's no way to pass the config on the commandline for .NETFramework. There might be an environment variable to set, barring that you could copy the config file. cc @ViktorHofer |
We have this code piece which should already cover the app.config scenario on .NET Framework: https://github.com/dotnet/arcade/blob/fc2f7ce8372a55725aab7b48c25bad7327a9769d/src/Microsoft.DotNet.RemoteExecutor/src/build/Microsoft.DotNet.RemoteExecutor.targets#L8-L33 Note that there is no plumbing required on .NET Framework as we directly execute the RemoteExecutor.exe executable and that by default already picks up the .config file with the same name. |
If it's being noise, I'm fine with turning the test off; and that's the only change I feel empowered to make. If infra wants to take a stab at making it work, that's cool with me. If not, off it goes. |
Adjusting the milestone since noone will look at 6.0.0. This is still failing regularly in servicing builds. |
Moving this out of 9.0.0, but when we do disable the test we should backport that to the servicing branches for 6.0, 8.0, and 9.0. |
Build Information
Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=734748
Build error leg or test failing:
System.Formats.Asn1.Tests.Reader.ReadObjectIdentifier.ReadVeryLongOid_WithAppContext
Error Message
Build windows x86 Release Libraries_NET48
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=734748
Error message validated:
[System.IO.FileLoadException: Could not load file or assembly 'System.Formats.Asn1
]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/9/2024 10:09:27 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: