-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Description
I would greatly appreciate having System.IO.Hashing be included in the base shared framework in .NET 11+ as it has a lot of use cases, plus it has no dependencies outside of the base shared framework anyways making it perfect to be included.
Also by including it, System.IO.Compression.Native could use it for the crc32 calculation and can stop exporting crc32 from zlib as I tested it myself and its Crc32.HashToUInt32 method results in the exact same hash as the one from zlib. With that it could actually be better as this would result in less code in System.IO.Compression.Native and would help clean it up a bit.
So yeah, I can see the pros of this outweighing the cons of adding System.IO.Hashing to the base shared framework. The nuget package version can still be produced however for those unable to upgrade their projects to .NET 11 or prefers to wait or for cases like Unity/c# analyzers/universal msbuild tasks where one would prefer/must target netstandard2.0.