Skip to content

Validating that we need the CI and PR containers #48789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richlander opened this issue May 1, 2025 · 3 comments
Open

Validating that we need the CI and PR containers #48789

richlander opened this issue May 1, 2025 · 3 comments
Labels
untriaged Request triage from a team member

Comments

@richlander
Copy link
Member

richlander commented May 1, 2025

I was looking at the various pipelines for this repo. From the perspective on main, they are all stale. We should / need to remediate all of them. Before we do that, it would good to understand why they are needed. My goal is that main is pristine before it enters servicing.

sdk/.vsts-pr.yml

Lines 29 to 39 in a1da6b6

containers:
- container: alpine319WithNode
image: mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.19-WithNode
- container: centosStream9
image: mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9
- container: debian12Amd64
image: mcr.microsoft.com/dotnet-buildtools/prereqs:debian-12-gcc14-amd64
- container: fedora39
image: mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-39
- container: ubuntu2204DebPkg
image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-debpkg

sdk/.vsts-ci.yml

Lines 66 to 76 in a1da6b6

containers:
alpine319WithNode:
image: mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.19-WithNode
centosStream9:
image: mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9
debian12Amd64:
image: mcr.microsoft.com/dotnet-buildtools/prereqs:debian-12-gcc14-amd64
fedora39:
image: mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-39
mariner20CrossArm:
image: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-cross-arm

@dotnet-policy-service dotnet-policy-service bot added the untriaged Request triage from a team member label May 1, 2025
@richlander
Copy link
Member Author

richlander commented May 1, 2025

@marcpopMSFT
Copy link
Member

These were copied over from the installer repo. We use all 5 in our PR pipeline and used to run the installer tests on them. They didn't work for the SDK tests so we disabled all tests in these legs for now but should bring back a subset of the tests. Maybe just the End2End.

For CI, we use alpine, centos, and mariner for building the various tars we ship.

I would have to defer to the A&D team over which of these are important to keep in the PR pipeline and how to upgrade them.

@richlander
Copy link
Member Author

@MichaelSimons @mthalman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants