Skip to content

Anchor links with no href should be ignored by markup plugin #1224

Open
@dylankelly

Description

@dylankelly

Describe the bug
A clear and concise description of what the bug is.

Anchor links that have no href attribute are being transformed into rpl-text-link when they should be treated as is.

See https://digital-engagement.atlassian.net/browse/SDPSUP-4363

To Reproduce
Steps to reproduce the behaviour:
1.
2.

Expected behaviour
A clear and concise description of what you expected to happen.

Actual behaviour
A clear and concise description of what is actually happening.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions

  • Ripple:

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Add condition in https://github.com/dpc-sdp/ripple/blob/develop/packages/ripple-nuxt-tide/lib/config/markup-plugins.js#L186 to ignore tag transformation if it has no href attribute.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions