Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excess cells in a table row disappear in output #37

Open
satyarohith opened this issue Mar 17, 2021 · 3 comments
Open

Excess cells in a table row disappear in output #37

satyarohith opened this issue Mar 17, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@satyarohith
Copy link
Contributor

Input

| name                                 |                   description                              |
| ------------------------ | ------------------------------ |
| `get(key: name): string | null` | Get the value of the string.             |

Expected output

| name                            | description                  |
| ------------------------------- | ---------------------------- |
| `get(key: name): string | null` | Get the value of the string. |

Actual output

| name                    | description |
| ----------------------- | ----------- |
| `get(key: name): string | null`       |
@dsherret dsherret added the bug Something isn't working label Mar 17, 2021
@dsherret
Copy link
Member

I looked into this and the pipe character needs to be escaped within the code block. https://stackoverflow.com/a/17320389/188246

That said, it shouldn't be swallowing the third column.

@dsherret
Copy link
Member

Opened pulldown-cmark/pulldown-cmark#520

@dsherret dsherret added the downstream The issue's cause occurs in a dependency. label Mar 20, 2021
@dsherret dsherret removed the downstream The issue's cause occurs in a dependency. label Apr 1, 2021
@dsherret
Copy link
Member

dsherret commented Apr 1, 2021

It looks like we will have to parse out extra cells manually. Some reading: https://github.github.com/gfm/#tables-extension-

I believe the extra cells could be parsed out, then the cell contents could be reparsed with pulldown-cmark. Kind of sucks though...

@dsherret dsherret changed the title Using pipe character in code blocks inside a table cell swallows the next cell Excess cells in a table row disappear in output Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants