-
Notifications
You must be signed in to change notification settings - Fork 328
feat: add last keep alive at tracking for scheduler service #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4213 +/- ##
=======================================
Coverage 32.62% 32.62%
=======================================
Files 350 350
Lines 41204 41216 +12
=======================================
+ Hits 13442 13447 +5
- Misses 26871 26879 +8
+ Partials 891 890 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2578c38
to
7476ba6
Compare
Signed-off-by: chlins <[email protected]>
7476ba6
to
b7e67a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces functionality to track the last heartbeat time of schedulers in the system. The changes include updates to the
Scheduler
model, modifications to RPC server methods for scheduler creation and updates, and enhancements to the keep-alive mechanism.Model Updates:
LastHeartbeat
field of typetime.Time
to theScheduler
struct to store the last heartbeat timestamp. (manager/models/scheduler.go
, manager/models/scheduler.goR39)time
package to support the new field. (manager/models/scheduler.go
, manager/models/scheduler.goR19-R20)RPC Server Enhancements:
UpdateScheduler
andcreateScheduler
methods to set theLastHeartbeat
field to the current time when a scheduler is updated or created. (manager/rpcserver/manager_server_v2.go
, [1] [2]KeepAlive
method to update theLastHeartbeat
field for schedulers upon successful keep-alive requests. (manager/rpcserver/manager_server_v2.go
, manager/rpcserver/manager_server_v2.goR874-R887)time
package to support the timestamp functionality in RPC server methods. (manager/rpcserver/manager_server_v2.go
, manager/rpcserver/manager_server_v2.goR24)Description
Related Issue
#4179
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist