-
Notifications
You must be signed in to change notification settings - Fork 328
feat: update d7y.io/api/v2 to v2.1.42 and report scheduler config to … #4214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
68d1dbc
to
4e713c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4214 +/- ##
==========================================
- Coverage 32.63% 32.62% -0.02%
==========================================
Files 350 350
Lines 41216 41235 +19
==========================================
Hits 13451 13451
- Misses 26877 26893 +16
- Partials 888 891 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…manager Signed-off-by: chlins <[email protected]>
4e713c5
to
af27781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces changes to update and manage scheduler configurations more effectively across the codebase. The most significant updates include modifications to handle scheduler configuration as JSON, changes to the
UpdateScheduler
andcreateScheduler
methods in themanagerServerV2
implementation, and updates to the scheduler announcer to report configuration to the manager.Scheduler configuration management:
manager/rpcserver/manager_server_v2.go
: Added logic to parse scheduler configuration from JSON (req.Config
) and integrate it into theUpdateScheduler
andcreateScheduler
methods. This ensures the configuration is properly unmarshaled and stored in theConfig
field of the scheduler model. [1] [2] [3] [4]Scheduler announcer updates:
scheduler/announcer/announcer.go
: Enhanced theNew
function to marshal scheduler configuration into JSON and include it in theUpdateSchedulerRequest
. This ensures the configuration is reported to the manager during scheduler registration. Added new imports for JSON handling and types. [1] [2] [3]Dependency update:
go.mod
: Updated the dependencyd7y.io/api/v2
from versionv2.1.39
tov2.1.42
. This may include bug fixes or new features relevant to the scheduler functionality.…managerDescription
Related Issue
#4179
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist