Skip to content

feat: update d7y.io/api/v2 to v2.1.42 and report scheduler config to … #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

chlins
Copy link
Member

@chlins chlins commented Jul 16, 2025

This pull request introduces changes to update and manage scheduler configurations more effectively across the codebase. The most significant updates include modifications to handle scheduler configuration as JSON, changes to the UpdateScheduler and createScheduler methods in the managerServerV2 implementation, and updates to the scheduler announcer to report configuration to the manager.

Scheduler configuration management:

  • manager/rpcserver/manager_server_v2.go: Added logic to parse scheduler configuration from JSON (req.Config) and integrate it into the UpdateScheduler and createScheduler methods. This ensures the configuration is properly unmarshaled and stored in the Config field of the scheduler model. [1] [2] [3] [4]

Scheduler announcer updates:

  • scheduler/announcer/announcer.go: Enhanced the New function to marshal scheduler configuration into JSON and include it in the UpdateSchedulerRequest. This ensures the configuration is reported to the manager during scheduler registration. Added new imports for JSON handling and types. [1] [2] [3]

Dependency update:

  • go.mod: Updated the dependency d7y.io/api/v2 from version v2.1.39 to v2.1.42. This may include bug fixes or new features relevant to the scheduler functionality.…manager

Description

Related Issue

#4179

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@chlins chlins added this to the v2.4.0 milestone Jul 16, 2025
@chlins chlins requested a review from a team as a code owner July 16, 2025 11:57
@chlins chlins added the enhancement New feature or request label Jul 16, 2025
@chlins chlins enabled auto-merge (squash) July 16, 2025 11:58
Liam-Zhao
Liam-Zhao previously approved these changes Jul 16, 2025
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gaius-qi
gaius-qi previously approved these changes Jul 16, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlins chlins dismissed stale reviews from gaius-qi and Liam-Zhao via 4e713c5 July 17, 2025 02:31
@chlins chlins force-pushed the feat/scheduler-config-report branch from 68d1dbc to 4e713c5 Compare July 17, 2025 02:31
Liam-Zhao
Liam-Zhao previously approved these changes Jul 17, 2025
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 32.62%. Comparing base (93dc9ef) to head (af27781).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/rpcserver/manager_server_v2.go 0.00% 12 Missing ⚠️
scheduler/announcer/announcer.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4214      +/-   ##
==========================================
- Coverage   32.63%   32.62%   -0.02%     
==========================================
  Files         350      350              
  Lines       41216    41235      +19     
==========================================
  Hits        13451    13451              
- Misses      26877    26893      +16     
- Partials      888      891       +3     
Flag Coverage Δ
unittests 32.62% <21.05%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/announcer/announcer.go 85.71% <57.14%> (-5.72%) ⬇️
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chlins chlins force-pushed the feat/scheduler-config-report branch from 4e713c5 to af27781 Compare July 17, 2025 04:05
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chlins chlins merged commit 3645302 into main Jul 17, 2025
16 checks passed
@chlins chlins deleted the feat/scheduler-config-report branch July 17, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants