Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded form component names #9

Open
sidneywidmer opened this issue Jul 23, 2018 · 1 comment
Open

Remove hardcoded form component names #9

sidneywidmer opened this issue Jul 23, 2018 · 1 comment

Comments

@sidneywidmer
Copy link

  • djangocms_spa version: f49db45
  • Django version: 1.11.11
  • Python version: 3.5.5
  • Operating System: macOS High Sierra (10.13.4)

Description

def _get_component_name(self):

Since this is just an arbitrary name used by the client side code, we should add an option to customise these. Possible solutions:

  • define the prefix cmp in the settings (probably this is enough for most use cases)
  • specify the names for each fieldtype manually in a settings dict or similar
  • do nothing and let the user overwrite the function every time he want's to have a custom name
@sidneywidmer
Copy link
Author

There are several other usages of the cmp prefix in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant