Merge pull request #412 from drewnoakes/collapse-asspan-slice

Collapse .AsSpan().Slice(...) calls into .AsSpan(...)

Author: drewnoakes

MetadataExtractor/Formats/Gif/GifReader.cs

@@ -369,7 +369,7 @@ private static byte[] GatherBytes(SequentialReader reader, byte firstLength)
 
             while (length > 0)
             {
-                reader.GetBytes(buffer.AsSpan().Slice(0, length));
+                reader.GetBytes(buffer.AsSpan(0, length));
 
                 stream.Write(buffer, 0, length);
 

MetadataExtractor/IO/BufferReader.Indexed.cs

@@ -195,7 +195,7 @@ public readonly string GetString(int index, int bytesRequested, Encoding encodin
         {
             byte[] bytes = ArrayPool<byte>.Shared.Rent(bytesRequested);
 
-            Span<byte> span = bytes.AsSpan().Slice(0, bytesRequested);
+            Span<byte> span = bytes.AsSpan(0, bytesRequested);
 
             GetBytes(index, span);
 

MetadataExtractor/IO/ByteArrayReader.cs

@@ -37,7 +37,7 @@ public override void GetBytes(int index, Span<byte> bytes)
         {
             ValidateIndex(index, bytes.Length);
 
-            _buffer.AsSpan().Slice(index + _baseOffset, bytes.Length).CopyTo(bytes);
+            _buffer.AsSpan(index + _baseOffset, bytes.Length).CopyTo(bytes);
         }
 
         protected override void ValidateIndex(int index, int bytesRequested)

MetadataExtractor/IO/IndexedCapturingReader.cs

@@ -165,7 +165,7 @@ public override void GetBytes(int index, Span<byte> bytes)
                 GetPosition(fromIndex, out int fromChunkIndex, out int fromInnerIndex);
                 var length = Math.Min(remaining, _chunkLength - fromInnerIndex);
                 var chunk = _chunks[fromChunkIndex];
-                chunk.AsSpan().Slice(fromInnerIndex, length).CopyTo(bytes.Slice(toIndex, length));
+                chunk.AsSpan(fromInnerIndex, length).CopyTo(bytes.Slice(toIndex, length));
                 remaining -= length;
                 fromIndex += length;
                 toIndex += length;

MetadataExtractor/IO/IndexedReader.cs

@@ -337,7 +337,7 @@ public string GetString(int index, int bytesRequested, Encoding encoding)
             {
                 byte[] bytes = ArrayPool<byte>.Shared.Rent(bytesRequested);
 
-                Span<byte> span = bytes.AsSpan().Slice(0, bytesRequested);
+                Span<byte> span = bytes.AsSpan(0, bytesRequested);
 
                 GetBytes(index, span);
 

MetadataExtractor/IO/SequentialReader.cs

@@ -238,7 +238,7 @@ public string GetString(int bytesRequested, Encoding encoding)
             {
                 byte[] bytes = ArrayPool<byte>.Shared.Rent(bytesRequested);
 
-                Span<byte> span = bytes.AsSpan().Slice(0, bytesRequested);
+                Span<byte> span = bytes.AsSpan(0, bytesRequested);
 
                 GetBytes(span);