Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

five MakerNote tags #425

Open
Charltsing opened this issue Jun 17, 2024 · 5 comments
Open

five MakerNote tags #425

Charltsing opened this issue Jun 17, 2024 · 5 comments
Labels
format-maker-notes help wanted image-queue Actionable issue with sample image

Comments

@Charltsing
Copy link

Exif.zip

it has 5 MakerNote tags, but only the last one is displayed

[Exif SubIFD] Makernote - 65 117 116 111 0

it should display : auto

@drewnoakes
Copy link
Owner

This suggests that we're not even attempting to decode the makernote. The code looks at the camera make and model and decides how to decode the makernote. If the make/model are not supported, then the raw bytes of the makernote are left alone, as shown here.

If you want to add support for this makernote, we'll accept a PR and can provide some guidance.

You may find that the excellent Exiftool docs already provide some info on the file format for this particular make/model.

@drewnoakes drewnoakes added format-maker-notes help wanted image-queue Actionable issue with sample image labels Jun 17, 2024
@Charltsing
Copy link
Author

As a temporary solution, it may be possible to add a Index number to all MakerNote tags and display all ascii characters for each

@drewnoakes
Copy link
Owner

I'm not sure how that would work generally. Most makernotes are binary encoded data.

@Charltsing
Copy link
Author

Perhaps all we need to do is read the ascii text

@drewnoakes
Copy link
Owner

That won't work in the general case. If you want to do that for your images, you can do so in your own code by getting the bytes and converting them to text explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format-maker-notes help wanted image-queue Actionable issue with sample image
Projects
None yet
Development

No branches or pull requests

2 participants