Diagnostic Session Control type is masked with 0x4F

[NicolasCayoux]

Hi,

On UDS Server, function "uint8_t _0x10_DiagnosticSessionControl(UDSServer_t *srv, UDSReq_t *r)"

The session type is masked with 0x4F
"uint8_t sessType = r->recv_buf[1] & 0x4F;"

Is there a specific reason to use this mask, instead of 0x7F ?
According to several UDS example on internet, the session type can be set between 0x01 and 0x7F

[driftregion]

Hi @NicolasCayoux , you're right, it should be 0x7F. Please feel free to open a PR.

[NicolasCayoux]

Hi @driftregion,
I try to open a branch "issue_64" to edit the code, but I don't have the permission to push the code.

The modification is
file src/server.c
ligne 34 (function static uint8_t _0x10_DiagnosticSessionControl(UDSServer_t *srv, UDSReq_t *r) )
uint8_t sessType = r->recv_buf[1] & 0x4F;
=>
uint8_t sessType = r->recv_buf[1] & 0x7F;

[driftregion]

OK, I'll make the change in the next release.

Alternately, you may fork the repository, push to your fork, and then make a PR (this is the GitHub way of making pull requests).