Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul "Donations" #1299

Open
efstajas opened this issue Oct 24, 2024 · 0 comments
Open

Overhaul "Donations" #1299

efstajas opened this issue Oct 24, 2024 · 0 comments

Comments

@efstajas
Copy link
Contributor

efstajas commented Oct 24, 2024

The are some glaring problems with the concept of "Donations" on Drips right now, which are mostly result of independently evolving functionality in different places over time. Let's revisit this concept holistically and clean things up a bit.

  • Merge conflated concepts of "Streams" and "Continuous Donations": Currently, you can go to a Drip List and create a "Continuous Donation", and this shows up on the Funds screen as a "Stream". There's also a "Create stream" button here which opens effectively the same modal as when you click Support -> Continuous Donation on a Project or Drip List. We should fix the terminology by referring to "Streams" as "Continuous Donations" all across the UX. Also, the Streams section on the Funds screen should probably be replaced with a Donations section that shows ongoing Continuous Donations alongside a history of One-Time Donations made by the currently-connected wallet.
  • Missing Support Card on Address Profiles. The Support Card appears on Drip Lists and Projects, but not on Address profiles. That's weird and there's no reason for it.
  • Unable to create a Continuous Donation directly to a Project: You can still only establish a Continuous Donation to Drip Lists (and addresses). There's no reason for that — it should be possible to continuously donate to projects too.
  • No date pickers on the Continuous Donation Creation Modal. Setting start & end dates is super awkward right now because you need to manually enter date strings in UTC. We already have a Date Picker component — let's use it.
  • Can't top-up a token together with creating a Continuous Donation: When you create a new Continuous Donation, you should be able to immediately top-up its token in the same TX. This is possible on the protocol level and would be useful, so let's allow it in the UX.
  • Different & separate Continuous Donation configurator in Create Drip List flow: There are two completely different modals used for when you configure a Continuous Donation within the Create Drip List flow, and when you later create a Continuous Donation on an existing Drip List. The one in the Create Drip List flow also doesn't allow setting start & end dates for the donation. There's no reason for these to be different.
  • Create Continuous Donation modal displays balances of your Drips account, but not ERC-20 balances in wallet: Currently, you have to first top up a token before you can select it in that modal. It should display all tokens, even those not yet topped-up. When selecting a token that is both topped-up and also has balance in the user's wallet, we should display both balances explicitly and allow topping up additional tokens.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant