#3: Fix PHPCS errors.

Author: Pol Dellaiera

src/Generators/Combinations.php

@@ -9,7 +9,7 @@
  *
  * @package drupol\phpermutations\Generators
  *
- * @author  Mark Wilson <[email protected]>
+ * @author Mark Wilson <[email protected]>
  */
 class Combinations extends CombinationsIterator {
 
@@ -28,19 +28,22 @@ public function generator() {
    *
    * @param array $dataset
    *   The dataset.
+   * @param int $length
+   *   The length.
    *
    * @codingStandardsIgnoreStart
    * @return \Generator
    * @codingStandardsIgnoreEnd
    */
   protected function get(array $dataset, $length) {
-    $originalLength  = count($dataset);
+    $originalLength = count($dataset);
     $remainingLength = $originalLength - $length + 1;
     for ($i = 0; $i < $remainingLength; $i++) {
       $current = $dataset[$i];
       if ($length === 1) {
         yield [$current];
-      } else {
+      }
+      else {
         $remaining = array_slice($dataset, $i + 1);
         foreach ($this->get($remaining, $length - 1) as $permutation) {
           array_unshift($permutation, $current);

src/Generators/Permutations.php

@@ -2,15 +2,14 @@
 
 namespace drupol\phpermutations\Generators;
 
-use drupol\phpermutations\Iterators\RangeIterator;
 use drupol\phpermutations\Permutations as PermutationsClass;
 
 /**
  * Class Permutations.
  *
  * @package drupol\phpermutations\Generators
  *
- * @author  Mark Wilson <[email protected]>
+ * @author Mark Wilson <[email protected]>
  */
 class Permutations extends PermutationsClass {
 

src/Iterators/Cycle.php

@@ -18,16 +18,6 @@ class Cycle extends Combinatorics implements \Iterator, \Countable {
    */
   protected $key = 0;
 
-  /**
-   * Cycle constructor.
-   *
-   * @param array $dataset
-   *   The dataset.
-   */
-  public function __construct(array $dataset = array()) {
-    parent::__construct($dataset);
-  }
-
   /**
    * {@inheritdoc}
    */

src/Iterators/FiniteGroup.php

@@ -146,14 +146,18 @@ private function gcd($a, $b) {
   }
 
   /**
-   * @param $generator
+   * Get the order.
+   *
+   * @param int $generator
+   *   The generator.
    *
    * @return int
+   *   The order.
    */
   public function order($generator) {
     $result = array();
 
-    foreach(range(1, $this->getSize() - 1) as $number) {
+    foreach (range(1, $this->getSize() - 1) as $number) {
       $value = pow($generator, $number) % $this->getSize();
       $result[$value] = $value;
     }

src/Permutations.php

@@ -11,18 +11,6 @@
  */
 class Permutations extends Combinatorics {
 
-  /**
-   * Permutations constructor.
-   *
-   * @param array $dataset
-   *   The dataset.
-   * @param int $length
-   *   The length of the requested permutations.
-   */
-  public function __construct(array $dataset = array(), $length = NULL) {
-    parent::__construct($dataset, $length);
-  }
-
   /**
    * Count the number of permutations.
    *

tests/src/Generators/CombinationsTest.php

@@ -3,7 +3,6 @@
 namespace drupol\phpermutations\Tests\Generators;
 
 use drupol\phpermutations\Generators\Combinations;
-use drupol\phpermutations\Permutations;
 use PHPUnit\Framework\TestCase;
 
 /**