Command to toogle Twig debugging and CSS/JS aggregation (#6268)

* Command to toogle Twig debugging and CSS/JS aggregation

* Code style fixes

* Changed command alias

* Renamed file and code improvements

* Fix CLI version error

* Add autowire

* remove twig:debug. it is broken anyway

* Use match

---------

Co-authored-by: KPL22 <[email protected]>
Co-authored-by: Moshe Weitzman <[email protected]>

Author: 3 people

src/Commands/LegacyCommands.php

@@ -43,4 +43,13 @@ public function secphp(): void
     public function sec(): void
     {
     }
+
+    /**
+     * twig:debug has been removed. Please use the `theme:dev` command.
+     */
+    #[CLI\Command(name: 'twig:debug', aliases: ['twig-debug'])]
+    #[CLI\Obsolete]
+    public function twigDebug(): void
+    {
+    }
 }

src/Commands/core/ThemeDevCommands.php

@@ -0,0 +1,75 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Drush\Commands\core;
+
+use Drupal\Core\Config\ConfigFactoryInterface;
+use Drupal\Core\KeyValueStore\KeyValueFactoryInterface;
+use Drush\Attributes as CLI;
+use Drush\Commands\AutowireTrait;
+use Drush\Commands\DrushCommands;
+use Symfony\Component\DependencyInjection\Attribute\Autowire;
+
+final class ThemeDevCommands extends DrushCommands
+{
+    use AutowireTrait;
+
+    const DEV = 'theme:dev';
+
+    public function __construct(
+        // @todo Can we avoid the autowire attribute here?
+        #[Autowire(service: 'keyvalue')]
+        protected KeyValueFactoryInterface $keyValueFactory,
+        protected ConfigFactoryInterface $configFactory
+    ) {
+        parent::__construct();
+    }
+
+    /**
+     * Toggle Twig development and cache aggregation settings.
+     *
+     * When enabled:
+     * - Disables render cache, dynamic page cache, and page cache.
+     * - Enables Twig debug mode (e.g., `dump()` function, template suggestions).
+     * - Disables Twig cache (templates always recompiled).
+     * - Disables CSS and JS aggregation.
+     *
+     * When disabled, restores default performance-oriented settings.
+     *
+     * Clears all Drupal caches to apply changes immediately.
+     */
+    #[CLI\Command(name: self::DEV, aliases: ['thdev'])]
+    #[CLI\Version(version: '13.6')]
+    #[CLI\Argument(name: 'mode', description: '"on" or "off"', suggestedValues: ['on', 'off'])]
+    #[CLI\Usage(name: 'drush theme:dev on', description: 'Disables CSS/JS aggregation and enables Twig debug settings.')]
+    #[CLI\Usage(name: 'drush theme:dev off', description: 'Enables CSS/JS aggregation and disables Twig debug settings.')]
+    public function toggleDevMode(string $mode): void
+    {
+        $devMode = match ($mode) {
+            'on' => true,
+            'off' => false,
+            default => throw new \InvalidArgumentException("Invalid mode. Use 'on' or 'off'."),
+        };
+
+        $this->keyValueFactory->get('development_settings')->setMultiple([
+            'disable_rendered_output_cache_bins' => $devMode,
+            'twig_debug' => $devMode,
+            'twig_cache_disable' => $devMode,
+        ]);
+
+        $this->configFactory->getEditable('system.performance')
+            ->set('css.preprocess', !$devMode)
+            ->set('js.preprocess', !$devMode)
+            ->save();
+
+        drupal_flush_all_caches();
+
+        $this->logger()->success(sprintf(
+            'Developer mode %s: CSS/JS aggregation %s, Twig debug settings %s.',
+            $devMode ? 'enabled' : 'disabled',
+            $devMode ? 'disabled' : 'enabled',
+            $devMode ? 'enabled' : 'disabled'
+        ));
+    }
+}

src/Commands/core/TwigCommands.php

@@ -5,11 +5,9 @@
 namespace Drush\Commands\core;
 
 use Consolidation\OutputFormatters\StructuredData\RowsOfFields;
-use Drupal\Core\DrupalKernelInterface;
 use Drupal\Core\Extension\ModuleExtensionList;
 use Drupal\Core\Extension\ModuleHandlerInterface;
 use Drupal\Core\PhpStorage\PhpStorageFactory;
-use Drupal\Core\State\StateInterface;
 use Drupal\Core\Template\TwigEnvironment;
 use Drush\Attributes as CLI;
 use Drush\Commands\AutowireTrait;
@@ -25,14 +23,11 @@ final class TwigCommands extends DrushCommands
 
     const UNUSED = 'twig:unused';
     const COMPILE = 'twig:compile';
-    const DEBUG = 'twig:debug';
 
     public function __construct(
         protected TwigEnvironment $twig,
         protected ModuleHandlerInterface $moduleHandler,
         private readonly ModuleExtensionList $extensionList,
-        private readonly StateInterface $state,
-        private readonly DrupalKernelInterface $kernel
     ) {
     }
 
@@ -112,30 +107,4 @@ public function twigCompile(): void
             $this->logger()->success(dt('Compiled twig template !path', ['!path' => $relative]));
         }
     }
-
-    /**
-     * Enables Twig debug and disables caching Twig templates.
-     *
-     * @see \Drupal\system\Form\DevelopmentSettingsForm::submitForm()
-     */
-    #[CLI\Command(name: self::DEBUG, aliases: ['twig-debug'])]
-    #[CLI\Argument(name: 'mode', description: 'Debug mode. Recognized values: <info>on</info>, <info>off</info>.', suggestedValues: ['on', 'off'])]
-    #[CLI\Version(version: '12.1')]
-    public function twigDebug(string $mode): void
-    {
-        $mode = match ($mode) {
-            'on' => true,
-            'off' => false,
-            default => throw new \Exception('Twig debug mode must be either "on" or "off".'),
-        };
-        $twig_development = [
-            'twig_debug' => $mode,
-            'twig_cache_disable' => $mode,
-        ];
-        $this->state->setMultiple($twig_development);
-        $this->kernel->invalidateContainer();
-        $this->io()->success(
-            dt('{operation} twig debug.', ['operation' => $mode ? 'Enabled' : 'Disabled']),
-        );
-    }
 }