Skip to content

Commit 4ad68a0

Browse files
committedNov 19, 2021
fix: triple reflection
1 parent 2c8648a commit 4ad68a0

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed
 

‎pkg/common/service.go

+5
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ type TripleGrpcService interface {
3030
XXX_ServiceDesc() *grpc.ServiceDesc
3131
}
3232

33+
// TripleGrpcReflectService is gRPC service, used to check impl
34+
type TripleGrpcReflectService interface {
35+
SetGRPCServer(s *grpc.Server)
36+
}
37+
3338
// TripleUnaryService is normal protocol service (except grpc service), should be implemented by users
3439
type TripleUnaryService interface {
3540
InvokeWithArgs(ctx context.Context, methodName string, arguments []interface{}) (interface{}, error)

‎pkg/triple/dubbo3_server.go

+9-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import (
3434
"github.com/dubbogo/grpc-go/encoding/msgpack"
3535
"github.com/dubbogo/grpc-go/encoding/proto_wrapper_api"
3636
"github.com/dubbogo/grpc-go/encoding/raw_proto"
37-
3837
perrors "github.com/pkg/errors"
3938
)
4039

@@ -238,10 +237,13 @@ func (t *TripleServer) Start() {
238237
desc := grpcService.XXX_ServiceDesc()
239238
desc.ServiceName = key.(string)
240239
grpcServer.RegisterService(desc, value)
241-
return true
240+
} else {
241+
desc := createGrpcDesc(key.(string), value.(common.TripleUnaryService))
242+
grpcServer.RegisterService(desc, value)
243+
}
244+
if key == "grpc.reflection.v1alpha.ServerReflection" {
245+
grpcService.(common.TripleGrpcReflectService).SetGRPCServer(grpcServer)
242246
}
243-
desc := createGrpcDesc(key.(string), value.(common.TripleUnaryService))
244-
grpcServer.RegisterService(desc, value)
245247
return true
246248
})
247249

@@ -263,6 +265,9 @@ func (t *TripleServer) RefreshService() {
263265
desc := createGrpcDesc(key.(string), value.(common.TripleUnaryService))
264266
grpcServer.RegisterService(desc, value)
265267
}
268+
if key == "grpc.reflection.v1alpha.ServerReflection" {
269+
grpcService.(common.TripleGrpcReflectService).SetGRPCServer(grpcServer)
270+
}
266271
return true
267272
})
268273
t.grpcServer.Stop()

0 commit comments

Comments
 (0)
Please sign in to comment.