Partial impl<'a> From<&'a Value> for ValueRef<'a> causes panics

[ianthetechie]

Title says it all. I got a bit of a nasty surprise when trying to pass a list of duckdb::types::value::Value::List as params when executing a statement. I'm sure there is some other way of passing a list of strings as a parameter, but I was quite surprised when I got a runtime panic due to the partial implementation of From. This should probably be TryFrom if it's not going to be implemented.

duckdb-rs/crates/duckdb/src/types/value_ref.rs

Lines 352 to 355 in 19acb89

	Value::Enum(..) => todo!(),
	Value::List(..) | Value::Struct(..) | Value::Map(..) | Value::Array(..) | Value::Union(..) => {
	unimplemented!()
	}

(Happy to work on a solution by the way; I don't quite grok what's supposed to be happening in this impl, but with a few pointers I'd be happy to work up a PR.

[rm-dr]

I agree. This is a bit annoying, as it makes code that theoretically works panic.

There isn't much we can do about this, though, until we implement the missing types!

[ianthetechie]

Maybe I missed something but does this have to be a From impl? I think that partial or failable conversions are the reason TryFrom exists.

[rm-dr]

This isn't a fallible conversion---it's simply unimplemented!
TryFrom might make sense, if the conversion is fallible when implemented.