Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue found on page 'Node.js Client (Neo)' #5169

Closed
flammel opened this issue Mar 28, 2025 · 1 comment
Closed

Issue found on page 'Node.js Client (Neo)' #5169

flammel opened this issue Mar 28, 2025 · 1 comment

Comments

@flammel
Copy link

flammel commented Mar 28, 2025

Hi,

I believe that the code example in the "Append To Table" section of the "Node.js Client (Neo)" contains an error in the line

const appender = await connection.createAppender('main', 'target_table');

In this example, the arguments to the createAppender function seem to be first the schema name and second the table name.
However, the method actually expects the arguments the other way around: https://github.com/duckdb/duckdb-node-neo/blob/6ecc181699291b3126e21a05f1531bfd55071d2d/api/src/DuckDBConnection.ts#L166

Page URL: https://duckdb.org/docs/stable/clients/node_neo/overview.html

@szarnyasg
Copy link
Collaborator

@flammel, thanks, indeed this was off. This has been fixed via #5173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants