-
Notifications
You must be signed in to change notification settings - Fork 7
Scalar function coverage #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalar function coverage #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
I can look into adding this to the template/ci tools:
The script for detecting coverage is definitely something we need, not sure how to tackle this. I see a few options:
maybe its not such a bad idea to have debug builds of DuckDB have the option of logging every C API call that is made. It will probably be really slow but it might be nice to have anyway? Ofc this would depend on the logging infrastructure to be there in time |
Great, yeah, the debugger and the formatter will be handy. Should we also slow down our additions here until we know which functions will be stable? The scalar function API and basic data chunk handling should be fine; we'll see. W.r.t. the logging, this is the cleanest solution. However, the Python parsing script should suffice until this repo/extension is close to completion. :) |
This PR covers all
...[scalar]...
functions in the C API.It also includes:
duckdb_state
returns state when registering the various scalar functions (still a big ugly...).The following would help with building this reference extension.
I'll also throw the command to get some debugging going in here.