Skip to content

Commit 96f7c1a

Browse files
committed
Add pixels and remove ATB
1 parent 5ba63b9 commit 96f7c1a

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ import com.duckduckgo.app.global.install.AppInstallStore
3838
import com.duckduckgo.app.global.install.daysInstalled
3939
import com.duckduckgo.app.onboarding.store.OnboardingStore
4040
import com.duckduckgo.app.pixels.AppPixelName
41+
import com.duckduckgo.app.pixels.AppPixelName.SITE_NOT_WORKING_SHOWN
42+
import com.duckduckgo.app.pixels.AppPixelName.SITE_NOT_WORKING_WEBSITE_BROKEN
4143
import com.duckduckgo.app.settings.db.SettingsDataStore
4244
import com.duckduckgo.app.statistics.pixels.Pixel
4345
import com.duckduckgo.app.statistics.pixels.Pixel.PixelValues.DAX_FIRE_DIALOG_CTA
@@ -1098,8 +1100,8 @@ sealed class HomePanelCta(
10981100
class BrokenSitePromptDialogCta() : Cta {
10991101

11001102
override val ctaId: CtaId = CtaId.BROKEN_SITE_PROMPT
1101-
override val shownPixel: Pixel.PixelName? = null
1102-
override val okPixel: Pixel.PixelName? = null
1103+
override val shownPixel: Pixel.PixelName = SITE_NOT_WORKING_SHOWN
1104+
override val okPixel: Pixel.PixelName = SITE_NOT_WORKING_WEBSITE_BROKEN
11031105
override val cancelPixel: Pixel.PixelName? = null
11041106

11051107
override fun pixelCancelParameters(): Map<String, String> = mapOf()

app/src/main/java/com/duckduckgo/app/global/api/PixelParamRemovalInterceptor.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ package com.duckduckgo.app.global.api
1919
import com.duckduckgo.app.browser.WebViewPixelName
2020
import com.duckduckgo.app.browser.httperrors.HttpErrorPixelName
2121
import com.duckduckgo.app.pixels.AppPixelName
22+
import com.duckduckgo.app.pixels.AppPixelName.SITE_NOT_WORKING_SHOWN
23+
import com.duckduckgo.app.pixels.AppPixelName.SITE_NOT_WORKING_WEBSITE_BROKEN
2224
import com.duckduckgo.app.statistics.pixels.Pixel
2325
import com.duckduckgo.common.utils.AppUrl
2426
import com.duckduckgo.common.utils.plugins.PluginPoint
@@ -86,6 +88,9 @@ object PixelInterceptorPixelsRequiringDataCleaning : PixelParamRemovalPlugin {
8688
HttpErrorPixelName.WEBVIEW_RECEIVED_HTTP_ERROR_400_DAILY.pixelName to PixelParameter.removeAtb(),
8789
HttpErrorPixelName.WEBVIEW_RECEIVED_HTTP_ERROR_4XX_DAILY.pixelName to PixelParameter.removeAtb(),
8890
HttpErrorPixelName.WEBVIEW_RECEIVED_HTTP_ERROR_5XX_DAILY.pixelName to PixelParameter.removeAtb(),
91+
SITE_NOT_WORKING_SHOWN.pixelName to PixelParameter.removeAtb(),
92+
SITE_NOT_WORKING_WEBSITE_BROKEN.pixelName to PixelParameter.removeAtb(),
93+
8994
)
9095
}
9196
}

app/src/main/java/com/duckduckgo/app/pixels/AppPixelName.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,6 +371,9 @@ enum class AppPixelName(override val pixelName: String) : Pixel.PixelName {
371371
RELOAD_TWICE_WITHIN_12_SECONDS("m_reload_twice_within_12_seconds"),
372372
RELOAD_THREE_TIMES_WITHIN_20_SECONDS("m_reload_three_times_within_20_seconds"),
373373

374+
SITE_NOT_WORKING_WEBSITE_BROKEN("site_not_working_website_is_broken"),
375+
SITE_NOT_WORKING_SHOWN("m.site_not_working_shown"),
376+
374377
URI_LOADED("m_uri_loaded"),
375378

376379
ERROR_PAGE_SHOWN("m_errorpageshown"),

0 commit comments

Comments
 (0)