This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Commit 66c516a
authored
Send pixel on sync secure storage read failure (#3530)
Task/Issue URL:
https://app.asana.com/0/1201493110486074/1208686320819590/f
**Description**:
On investigating a hard-to-reproduce issue with sync, I noticed there's
a gap in error reporting when the secure storage (keychain) is not
available. This adds a pixel for that case.
**Steps to test this PR**:
Just a pixel in an error case. Hard to test without altering code. But
if you do want to do that:
1. Enable sync
2. Change `BSK.DDGSync.SecureStorage.account()` to throw every time
3. Go to the Settings -> Sync screen
4. You should see the `sync_secure_storage_read_error` Pixel in the
debug console
**Definition of Done (Internal Only)**:
* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
**Copy Testing**:
* [ ] Use of correct apostrophes in new copy, ie `’` rather than `'`
**Orientation Testing**:
* [ ] Portrait
* [ ] Landscape
**Device Testing**:
* [ ] iPhone SE (1st Gen)
* [ ] iPhone 8
* [ ] iPhone X
* [ ] iPhone 14 Pro
* [ ] iPad
**OS Testing**:
* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17
**Theme Testing**:
* [ ] Light theme
* [ ] Dark theme
---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)1 parent b1cb778 commit 66c516a
File tree
4 files changed
+7
-3
lines changed- Core
- DuckDuckGo.xcodeproj
4 files changed
+7
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
624 | 624 | | |
625 | 625 | | |
626 | 626 | | |
| 627 | + | |
627 | 628 | | |
628 | 629 | | |
629 | 630 | | |
| |||
1432 | 1433 | | |
1433 | 1434 | | |
1434 | 1435 | | |
| 1436 | + | |
1435 | 1437 | | |
1436 | 1438 | | |
1437 | 1439 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
| 104 | + | |
103 | 105 | | |
104 | 106 | | |
105 | 107 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10970 | 10970 | | |
10971 | 10971 | | |
10972 | 10972 | | |
10973 | | - | |
| 10973 | + | |
10974 | 10974 | | |
10975 | 10975 | | |
10976 | 10976 | | |
| |||
Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments