Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 98bf8bd

Browse files
committed
Point to BSK branch and handle new error
1 parent 82f02f0 commit 98bf8bd

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

Core/PixelEvent.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -622,6 +622,7 @@ extension Pixel {
622622
case syncRemoveDeviceError
623623
case syncDeleteAccountError
624624
case syncLoginExistingAccountError
625+
case syncSecureStorageReadError
625626

626627
case syncGetOtherDevices
627628
case syncGetOtherDevicesCopy
@@ -1430,6 +1431,7 @@ extension Pixel.Event {
14301431
case .syncRemoveDeviceError: return "m_d_sync_remove_device_error"
14311432
case .syncDeleteAccountError: return "m_d_sync_delete_account_error"
14321433
case .syncLoginExistingAccountError: return "m_d_sync_login_existing_account_error"
1434+
case .syncSecureStorageReadError: return "m_d_sync_secure_storage_error"
14331435

14341436
case .syncGetOtherDevices: return "sync_get_other_devices"
14351437
case .syncGetOtherDevicesCopy: return "sync_get_other_devices_copy"

Core/SyncErrorHandler.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ public class SyncErrorHandler: EventMapping<SyncError> {
100100
Pixel.fire(pixel: .syncFailedToLoadAccount, error: error)
101101
case .failedToSetupEngine:
102102
Pixel.fire(pixel: .syncFailedToSetupEngine, error: error)
103+
case .failedToReadSecureStore(let status):
104+
Pixel.fire(pixel: .syncSecureStorageReadError, error: error)
103105
default:
104106
// Should this be so generic?
105107
let domainEvent = Pixel.Event.syncSentUnauthenticatedRequest

DuckDuckGo.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10953,8 +10953,8 @@
1095310953
isa = XCRemoteSwiftPackageReference;
1095410954
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
1095510955
requirement = {
10956-
kind = exactVersion;
10957-
version = 201.0.0;
10956+
branch = "graeme/send-pixel-on-sync-secure-storage-failure";
10957+
kind = branch;
1095810958
};
1095910959
};
1096010960
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

0 commit comments

Comments
 (0)